Telemetry smoothness test reports the wrong frame_times for viz |
||||
Issue descriptiontelemetry smoothness test normally reports frame_times from the display compositor in the browser. However, with the display compositor in the gpu process for viz, the smoothness test reports frame_times from the layer compositor in the browser. To be able to correctly compare: telemetry should report frame_times from the gpu process with viz.
,
Oct 31 2017
,
Oct 31 2017
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81b903e31d80145709eb03b27b7ace1dddf319d4 commit 81b903e31d80145709eb03b27b7ace1dddf319d4 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue Oct 31 08:35:05 2017 Roll src/third_party/catapult/ 6fd9f08dc..d62be5b8d (4 commits) https://chromium.googlesource.com/catapult.git/+log/6fd9f08dcb0b..d62be5b8d845 $ git log 6fd9f08dc..d62be5b8d --date=short --no-merges --format='%ad %ae %s' 2017-10-30 sadrul telemetry smoothness: Ignore the renderer for frame times. 2017-10-30 wkorman Increase timeout for expensive JS operations. 2017-10-30 charliea Remove more MSR-focused Telemetry power code 2017-10-27 oysteine py_vulcanize: Support a list of scripts to ignore Created with: roll-dep src/third_party/catapult BUG= 779316 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I826b95dfe8129dd4c42b2e6d96294738e67b3d90 Reviewed-on: https://chromium-review.googlesource.com/745823 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512780} [modify] https://crrev.com/81b903e31d80145709eb03b27b7ace1dddf319d4/DEPS
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/f742ce0719d0d7fceb055dcfa5e2179ff94766f5 commit f742ce0719d0d7fceb055dcfa5e2179ff94766f5 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Oct 31 20:17:06 2017 viz: Fix collecting rendering stats with viz. With viz, the display compositor lives in the gpu process. So it is possible for the gpu process to have rendering stats. So update the code to handle that case. Also, with the mojo viz service, the thread is called 'VizMain'. So check for a thread with that name to determine if it's the gpu process. BUG= chromium:779316 Change-Id: Id95368745942978b4e5233d264af727c6b1c6c90 Reviewed-on: https://chromium-review.googlesource.com/742662 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/f742ce0719d0d7fceb055dcfa5e2179ff94766f5/telemetry/telemetry/timeline/trace_event_importer.py [modify] https://crrev.com/f742ce0719d0d7fceb055dcfa5e2179ff94766f5/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py [modify] https://crrev.com/f742ce0719d0d7fceb055dcfa5e2179ff94766f5/telemetry/telemetry/web_perf/metrics/rendering_stats.py
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/7208715925a6d452c77dfb368c0df091066be29c commit 7208715925a6d452c77dfb368c0df091066be29c Author: Juan Antonio Navarro Pérez <perezju@chromium.org> Date: Thu Nov 02 09:13:47 2017 Revert "viz: Fix collecting rendering stats with viz." This reverts commit f742ce0719d0d7fceb055dcfa5e2179ff94766f5. Reason for revert: Blocking catapult roll Causes test to fail: measurements.smoothness_unittest.SmoothnessUnitTest.testSmoothnessSurfaceFlingerMetricsCalculated For example: https://luci-milo.appspot.com/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/294151 Original change's description: > viz: Fix collecting rendering stats with viz. > > With viz, the display compositor lives in the gpu process. So it > is possible for the gpu process to have rendering stats. So update > the code to handle that case. > > Also, with the mojo viz service, the thread is called 'VizMain'. > So check for a thread with that name to determine if it's the gpu > process. > > BUG= chromium:779316 > > Change-Id: Id95368745942978b4e5233d264af727c6b1c6c90 > Reviewed-on: https://chromium-review.googlesource.com/742662 > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> TBR=sadrul@chromium.org,vmiura@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:779316 Change-Id: I18f2addb1da07130f9f366761bae59ac9ec20136 Reviewed-on: https://chromium-review.googlesource.com/750801 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/7208715925a6d452c77dfb368c0df091066be29c/telemetry/telemetry/timeline/trace_event_importer.py [modify] https://crrev.com/7208715925a6d452c77dfb368c0df091066be29c/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py [modify] https://crrev.com/7208715925a6d452c77dfb368c0df091066be29c/telemetry/telemetry/web_perf/metrics/rendering_stats.py
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b86df1f4623bc360b846fbf93953280240a5dccf commit b86df1f4623bc360b846fbf93953280240a5dccf Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Thu Nov 02 11:41:54 2017 Roll src/third_party/catapult/ 14715602e..720871592 (8 commits) https://chromium.googlesource.com/catapult.git/+log/14715602e04a..7208715925a6 $ git log 14715602e..720871592 --date=short --no-merges --format='%ad %ae %s' 2017-11-02 perezju Revert "viz: Fix collecting rendering stats with viz." 2017-11-01 johnchen Update media metric to support multiple media in a trace 2017-10-31 benjhayden Encode unicode as ascii in mre/gtest_progress_reporter.py. 2017-11-01 perezju [Telemetry] Do not collect histograms when not requited by output 2017-11-01 rnephew [Telemetry] Change error message when platform is not supported. 2017-10-31 achuith Catch exception when oobe disappears. 2017-10-31 simonhatch Pinpoint - Easy button. 2017-10-30 sadrul viz: Fix collecting rendering stats with viz. Created with: roll-dep src/third_party/catapult BUG= 779910 , 779316 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I818a4a7d7b572eb2cec9157685327d5de7f27746 Reviewed-on: https://chromium-review.googlesource.com/750258 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513458} [modify] https://crrev.com/b86df1f4623bc360b846fbf93953280240a5dccf/DEPS
,
Nov 8 2017
Migrating from Internals>Viz to Internals>Services>Viz.
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/8f54ec4b08dbfaaeda79c23260923eb15a7ca86c commit 8f54ec4b08dbfaaeda79c23260923eb15a7ca86c Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Wed Nov 08 21:50:01 2017 Reland "viz: Fix collecting rendering stats with viz." This is a reland of f742ce0719d0d7fceb055dcfa5e2179ff94766f5 Original change's description: > viz: Fix collecting rendering stats with viz. > > With viz, the display compositor lives in the gpu process. So it > is possible for the gpu process to have rendering stats. So update > the code to handle that case. > > Also, with the mojo viz service, the thread is called 'VizMain'. > So check for a thread with that name to determine if it's the gpu > process. > > BUG= chromium:779316 > > Change-Id: Id95368745942978b4e5233d264af727c6b1c6c90 > Reviewed-on: https://chromium-review.googlesource.com/742662 > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> Bug: chromium:779316 Change-Id: I86a3824766d04fb0c2b1588ea47a860b0a2c3b3b Reviewed-on: https://chromium-review.googlesource.com/756653 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> [modify] https://crrev.com/8f54ec4b08dbfaaeda79c23260923eb15a7ca86c/telemetry/telemetry/timeline/trace_event_importer.py [modify] https://crrev.com/8f54ec4b08dbfaaeda79c23260923eb15a7ca86c/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py [modify] https://crrev.com/8f54ec4b08dbfaaeda79c23260923eb15a7ca86c/telemetry/telemetry/web_perf/metrics/rendering_stats.py
,
Nov 13 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Oct 31 2017