New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779280 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

LatencyInfo is coalesced in GPU Swap

Project Member Reported by dtapu...@chromium.org, Oct 27 2017

Issue description

We shouldn't be getting a GPU swap with coalesced latency info.

See
https://chromium-review.googlesource.com/c/chromium/src/+/738441#message-d4b57c08ccb8055842a4f93a90c87ec18d685b60


Reporter indicates navigating to file:///sdcard with dcheck on causes the issue.
 
Labels: -Pri-3 Pri-1
I believe this is related to 

https://cs.chromium.org/chromium/src/ui/events/blink/compositor_thread_event_queue.cc?sq=package:chromium&l=66

and
https://cs.chromium.org/chromium/src/ui/events/blink/compositor_thread_event_queue.cc?sq=package:chromium&l=47

These set_coalesced calls make no sense to me. I think we should remove them will try to debug on Monday.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d369911c9ff7aa9444516179120e727da3641d4

commit 4d369911c9ff7aa9444516179120e727da3641d4
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Oct 31 13:25:47 2017

Vsync aligned gesture events setting coalesced bit.

Do not set the coalesced bit on vsync aligned gestures. These are the
original latency_info objects so they aren't coalesced the other ones
are set as coalesced in the event queue. This code caused DCHECKs to fire
in the browser once the coalesced bit was propagated correctly.

BUG= 779280 

Change-Id: Ia873f4ebd5b4cb22fcf40033775cf8618f80b959
Reviewed-on: https://chromium-review.googlesource.com/744801
Reviewed-by: Chong Zhang <chongz@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512806}
[modify] https://crrev.com/4d369911c9ff7aa9444516179120e727da3641d4/ui/events/blink/compositor_thread_event_queue.cc

Status: Fixed (was: Assigned)
Cc: dtapu...@chromium.org
 Issue 780274  has been merged into this issue.

Sign in to add a comment