New issue
Advanced search Search tips

Issue 779273 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add autotest for unclean shutdown with component update.

Project Member Reported by kerrnel@chromium.org, Oct 27 2017

Issue description

We need an autotest to check for unclean shutdown when component updates are mounted on the device.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cfad09c264a82047e52e0a8a260d6dba8f029ff9

commit cfad09c264a82047e52e0a8a260d6dba8f029ff9
Author: Greg Kerr <kerrnel@chromium.org>
Date: Thu Nov 09 06:21:51 2017

component_UpdateFlash: Check for clean shutdown.

This updates the component_UpdateFlash check to test for clean
shutdown. The bug causing the dangling reference counts on unmount only
occurs if the UI actually loads and uses the flash library, so this case
needs to be checked in the actual component flash test.

BUG= chromium:779273 
TEST=emerge-${BOARD} autotest-tests

Change-Id: I6d2cafe19e673e4df179a04f609a0b80af51f27d
Reviewed-on: https://chromium-review.googlesource.com/756321
Commit-Ready: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/cfad09c264a82047e52e0a8a260d6dba8f029ff9/client/site_tests/platform_CleanShutdown/control
[modify] https://crrev.com/cfad09c264a82047e52e0a8a260d6dba8f029ff9/server/site_tests/component_UpdateFlash/component_UpdateFlash.py
[modify] https://crrev.com/cfad09c264a82047e52e0a8a260d6dba8f029ff9/client/site_tests/platform_CleanShutdown/platform_CleanShutdown.py

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bd37540d22ff39693a67f32a2e05c5134968764e

commit bd37540d22ff39693a67f32a2e05c5134968764e
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Fri Nov 10 06:29:57 2017

component_UpdateFlash: raise failure.

BUG= chromium:779273 
TEST=None.

Change-Id: I2d4f5a74eccd04bf550875a9cdff5be05a9fcca5
Reviewed-on: https://chromium-review.googlesource.com/763069
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/bd37540d22ff39693a67f32a2e05c5134968764e/server/site_tests/component_UpdateFlash/component_UpdateFlash.py

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 11 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6a9e518b3ffafc9b4892d0656b288042f277ce87

commit 6a9e518b3ffafc9b4892d0656b288042f277ce87
Author: Greg Kerr <kerrnel@chromium.org>
Date: Sat Nov 11 01:56:09 2017

component_UpdateFlash: Check for clean shutdown.

This updates the component_UpdateFlash check to test for clean
shutdown. The bug causing the dangling reference counts on unmount only
occurs if the UI actually loads and uses the flash library, so this case
needs to be checked in the actual component flash test.

BUG= chromium:779273 
TEST=emerge-${BOARD} autotest-tests

Change-Id: I6d2cafe19e673e4df179a04f609a0b80af51f27d
Reviewed-on: https://chromium-review.googlesource.com/756321
Commit-Ready: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit cfad09c264a82047e52e0a8a260d6dba8f029ff9)
Reviewed-on: https://chromium-review.googlesource.com/764728
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/6a9e518b3ffafc9b4892d0656b288042f277ce87/client/site_tests/platform_CleanShutdown/control
[modify] https://crrev.com/6a9e518b3ffafc9b4892d0656b288042f277ce87/server/site_tests/component_UpdateFlash/component_UpdateFlash.py
[modify] https://crrev.com/6a9e518b3ffafc9b4892d0656b288042f277ce87/client/site_tests/platform_CleanShutdown/platform_CleanShutdown.py

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 11 2017

Labels: merge-merged-release-R62-9901.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f54ca146e3fb468451da88255bf146b1c50f8020

commit f54ca146e3fb468451da88255bf146b1c50f8020
Author: Greg Kerr <kerrnel@chromium.org>
Date: Sat Nov 11 01:56:30 2017

component_UpdateFlash: Check for clean shutdown.

This updates the component_UpdateFlash check to test for clean
shutdown. The bug causing the dangling reference counts on unmount only
occurs if the UI actually loads and uses the flash library, so this case
needs to be checked in the actual component flash test.

BUG= chromium:779273 
TEST=emerge-${BOARD} autotest-tests

Change-Id: I6d2cafe19e673e4df179a04f609a0b80af51f27d
Reviewed-on: https://chromium-review.googlesource.com/756321
Commit-Ready: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit cfad09c264a82047e52e0a8a260d6dba8f029ff9)
Reviewed-on: https://chromium-review.googlesource.com/764728
Tested-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit 6a9e518b3ffafc9b4892d0656b288042f277ce87)
Reviewed-on: https://chromium-review.googlesource.com/764729

[modify] https://crrev.com/f54ca146e3fb468451da88255bf146b1c50f8020/client/site_tests/platform_CleanShutdown/control
[modify] https://crrev.com/f54ca146e3fb468451da88255bf146b1c50f8020/server/site_tests/component_UpdateFlash/component_UpdateFlash.py
[modify] https://crrev.com/f54ca146e3fb468451da88255bf146b1c50f8020/client/site_tests/platform_CleanShutdown/platform_CleanShutdown.py

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/349469e501bc3b3e19bcf329cb9f498d6bd2bd82

commit 349469e501bc3b3e19bcf329cb9f498d6bd2bd82
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Sat Nov 11 01:56:49 2017

component_UpdateFlash: raise failure.

BUG= chromium:779273 
TEST=None.

Change-Id: I2d4f5a74eccd04bf550875a9cdff5be05a9fcca5
Reviewed-on: https://chromium-review.googlesource.com/763069
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit bd37540d22ff39693a67f32a2e05c5134968764e)
Reviewed-on: https://chromium-review.googlesource.com/764730

[modify] https://crrev.com/349469e501bc3b3e19bcf329cb9f498d6bd2bd82/server/site_tests/component_UpdateFlash/component_UpdateFlash.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f8441f883220d54e48eb5147b7eaa8e306290c2d

commit f8441f883220d54e48eb5147b7eaa8e306290c2d
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Sat Nov 11 01:57:13 2017

component_UpdateFlash: raise failure.

BUG= chromium:779273 
TEST=None.

Change-Id: I2d4f5a74eccd04bf550875a9cdff5be05a9fcca5
Reviewed-on: https://chromium-review.googlesource.com/763069
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit bd37540d22ff39693a67f32a2e05c5134968764e)
Reviewed-on: https://chromium-review.googlesource.com/764730
(cherry picked from commit 349469e501bc3b3e19bcf329cb9f498d6bd2bd82)
Reviewed-on: https://chromium-review.googlesource.com/764731

[modify] https://crrev.com/f8441f883220d54e48eb5147b7eaa8e306290c2d/server/site_tests/component_UpdateFlash/component_UpdateFlash.py

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8a05dd4cdb2c591e7e41424a27511dade7caa7d3

commit 8a05dd4cdb2c591e7e41424a27511dade7caa7d3
Author: Greg Kerr <kerrnel@chromium.org>
Date: Sat Nov 18 04:18:43 2017

platform_CleanShutdown: Cleanup the umount_failure file between runs.

This updates the autotest to delete the umount_failure file after
running. Otherwise the autotest only knows that the machine once had an
unclean shutdown, and knowing that the last shutdown wasn't clean is the
desired state.

BUG= chromium:779273 
TEST=test_that -b ${BOARD} ${DUT_IP} platform_CleanShutdown

Change-Id: Id052432e2bdbfe074a2df65d75b9a1b1b4cacd13
Reviewed-on: https://chromium-review.googlesource.com/767040
Commit-Ready: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/8a05dd4cdb2c591e7e41424a27511dade7caa7d3/client/site_tests/platform_CleanShutdown/platform_CleanShutdown.py

Status: Fixed (was: Started)
Status: Archived (was: Fixed)

Sign in to add a comment