New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779269 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 764125



Sign in to add a comment

MD Extensions: A11y: Button is double labelled

Project Member Reported by hcarmona@chromium.org, Oct 27 2017

Issue description

What steps will reproduce the problem?
1. Install an extension
2. View details for extension in MD Extensions
3. Use chromevox to focus button in screenshot

What is the expected result?
Chromevox should only read the button label once to avoid annoying our users
 
double-lable.png
60.2 KB View Download
Blocking: 764125
Owner: hcarmona@chromium.org
Status: Started (was: Available)
This affects all cr-link-row elements including the ones used in chrome://settings/
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9934c70a8923bbf453fa8112f0a3450a4532cd31

commit 9934c70a8923bbf453fa8112f0a3450a4532cd31
Author: Hector Carmona <hcarmona@chromium.org>
Date: Tue Nov 14 23:05:07 2017

MD-Extension/MD-Settings: A11y - Hide the icon from cr-link-row.

The cr-link-row is treated as a single clickable surface. By labeling
the icon, we were causing a11y tools to read that label twice. Hiding
the icon as it doesn't convey any useful info for a11y and is purely
decorative.

Bug:  779269 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I27b57d1611c596182af5aafd1c549b3a6842e28e
Reviewed-on: https://chromium-review.googlesource.com/767069
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516484}
[modify] https://crrev.com/9934c70a8923bbf453fa8112f0a3450a4532cd31/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html

Status: Fixed (was: Started)

Comment 6 by hdodda@chromium.org, Nov 15 2017

Cc: hdodda@chromium.org
Labels: Needs-Feedback
Tested the issue on windows 10, Mac OS 10.12.6 , ubuntu 14.04 using chrome M64 #64.0.3269.0 and followed the steps mentioned in comment #0.

Observed that Chrome Vox is not highlighting the text in chrome:/extensions page or chrome://settings.

Attached screencast for reference.

@hcarmona-- Could you please check attached screencast and confirm us if this is the expected result or given fix , so that we can continue adding TE verified labels.

Thanks!


779269.mp4
1.1 MB View Download

Sign in to add a comment