New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779266 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Add a button to ignore PreviewsBlackList decisions on chrome://interventions-internals

Project Member Reported by thanhdle@chromium.org, Oct 27 2017

Issue description

Add a button to chrome://interventions-internals on the "Blacklist Status" tab that can ignore PreviewsBlackList decisions of when to show previews.

Toggle the button will re-enable the PreviewsBlackList decision.
 
 Issue 762619  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39dfdd5ece08d0b7c42c085a779ef08350d79d9d

commit 39dfdd5ece08d0b7c42c085a779ef08350d79d9d
Author: Thanh Le <thanhdle@chromium.org>
Date: Fri Nov 03 08:22:12 2017

Add button to ignore/enable blacklist decisions on
chrome://interventions-internals.

When the button is clicked the state of ignore blacklist decisions is reversed.
This enable the page to temporarily ignore the state of PreviewsBlackList
decisions for testing. PreviewsBlackList is still updated (e.g. if a new host is
blacklisted while the blacklist decisions are ignored, it is still being record
to the blacklist).

Multiple instances of the InterventionsInternalsPageHandler will be updated if
the ignore status is changed, so that they have the correct status shown on the
page.

When the last instance of chrome://interventions-internals page is closed, the
state of PreviewsBlackList decisions is reset (i.e. no longer ignored).

Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3dW9JYmpSakVZaU0/view?usp=sharing
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3ZkdXdG1lMUltYTA/view?usp=sharing
Bug:  779266 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icce22eaddd0f6e34e215f8914bd461f3bec7a065
Reviewed-on: https://chromium-review.googlesource.com/742701
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513724}
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/browser/resources/interventions_internals/index.html
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/browser/ui/webui/interventions_internals/interventions_internals.mojom
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.h
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.cc
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.h
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/chrome/test/data/webui/interventions_internals_browsertest.js
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_io_data.cc
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_io_data.h
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_io_data_unittest.cc
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_logger.cc
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_logger.h
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_logger_observer.h
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_logger_unittest.cc
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_ui_service.cc
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_ui_service.h
[modify] https://crrev.com/39dfdd5ece08d0b7c42c085a779ef08350d79d9d/components/previews/core/previews_ui_service_unittest.cc

Status: Fixed (was: Started)

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 5 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment