SyncedPrintersManager doesn't check return value of RecommendedPrinterToPrinter |
||||
Issue descriptionIf RecommendedPrinterToPrinter encounters malformed data, it returns nullptr. The result of RecommendedPrinterToPrinter is dereferenced without check here: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/printing/synced_printers_manager.cc?rcl=bffba4c8522243ce909acd9006d1df4d29b7d2c9&l=203 We should fix that. NOte this should only be triggerable by bad enterprise data, which is already moderately trusted by a given chromebook, and then only if they go to print, so marking as P1.
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df204d2700b125fd0dd3d9d78f494d516e2e0130 commit df204d2700b125fd0dd3d9d78f494d516e2e0130 Author: David Valleau <valleau@chromium.org> Date: Mon Nov 13 18:07:34 2017 Adding a check for nullptr in UpdateRecommendedPrinters R=skau@chromium.org Bug: 779256 Change-Id: I5772282ee310a594b5e31d5931fa38a6fa67cde8 Reviewed-on: https://chromium-review.googlesource.com/755417 Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#515980} [modify] https://crrev.com/df204d2700b125fd0dd3d9d78f494d516e2e0130/chrome/browser/chromeos/printing/synced_printers_manager.cc
,
Nov 13 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by skau@chromium.org
, Nov 3 2017Owner: valleau@chromium.org
Status: Assigned (was: Available)