New issue
Advanced search Search tips

Issue 779238 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move old media-related fuzzers from //testing/libfuzzer/fuzzers to //media/...

Project Member Reported by wolenetz@chromium.org, Oct 27 2017

Issue description

Many of the first fuzzers were implemented under //testing, including a
few MSE-related fuzzers.

This bug tracks follow-up of CR comment:
Per mmoroz@ on https://chromium-review.googlesource.com/c/chromium/src/+/729705/8/testing/libfuzzer/fuzzers/mp4_box_reader_fuzzer.cc#26:
"Can we move this target to //media land? We are trying to store fuzzers closer to the code they are targeting. This is one of the very first fuzzers, this is why it got landed here."

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1b815290d83b4fbe74c6b194d0c822efca7f361

commit f1b815290d83b4fbe74c6b194d0c822efca7f361
Author: Matt Wolenetz <wolenetz@chromium.org>
Date: Mon Oct 30 18:35:45 2017

MSE: Relocate fuzzers from //testing/libfuzzer/fuzzers to //media/...

Many of the first fuzzers were implemented under //testing, including a
few MSE-related fuzzers. This change moves those MSE fuzzers closer to
the code they test under //media.

BUG= 779238 

Change-Id: Ied496bbaa78864e54d670cc549da46bdd09eeeb2
Reviewed-on: https://chromium-review.googlesource.com/742452
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512536}
[modify] https://crrev.com/f1b815290d83b4fbe74c6b194d0c822efca7f361/media/BUILD.gn
[rename] https://crrev.com/f1b815290d83b4fbe74c6b194d0c822efca7f361/media/formats/mp2t/es_parser_adts_fuzzer.cc
[rename] https://crrev.com/f1b815290d83b4fbe74c6b194d0c822efca7f361/media/formats/mp2t/es_parser_h264_fuzzer.cc
[rename] https://crrev.com/f1b815290d83b4fbe74c6b194d0c822efca7f361/media/formats/mp2t/es_parser_mpeg1audio_fuzzer.cc
[rename] https://crrev.com/f1b815290d83b4fbe74c6b194d0c822efca7f361/media/formats/mp4/mp4_box_reader_fuzzer.cc
[rename] https://crrev.com/f1b815290d83b4fbe74c6b194d0c822efca7f361/media/test/mp4.dict
[modify] https://crrev.com/f1b815290d83b4fbe74c6b194d0c822efca7f361/testing/libfuzzer/fuzzers/BUILD.gn

Comment 2 by mmoroz@google.com, Oct 31 2017

I've migrated the corpus and old fuzzer stats data.
mmoroz@, on the stats page, I see nothing prior to ~Oct 30 for:
libFuzzer_media_es_parser_mpeg1audio_fuzzer
libFuzzer_media_es_parser_adts_fuzzer
libFuzzer_media_es_parser_h264_fuzzer
libFuzzer_media_mp4_box_reader_fuzzer

Does this mean corpus or old stats *didn't* get migrated?


Labels: Needs-Feedback
Hmm, I see. Looks like I need to rename the stats somewhere else. Thanks for catching! I'm taking a closer look now.
Labels: -Needs-Feedback
I think I found what I've missed. Updating now and re-checking.
Alright, I got different execution stats, but not coverage and corpus numbers so far: https://clusterfuzz.com/v2/fuzzer-stats/by-day/2017-10-03/2017-11-06/fuzzer/libFuzzer_media_es_parser_mpeg1audio_fuzzer
Performance report link is there: https://clusterfuzz.com/v2/fuzzer-stats/by-day/2017-10-03/2017-11-06/fuzzer/libFuzzer_media_es_parser_mpeg1audio_fuzzer/job/libfuzzer_chrome_asan

And coverage numbers are also working now.

Corpus backup links are not updated, since we store backups only for a couple of weeks.
And finally coverage reports have been migrated as well. I think I'm done now :)
Status: Fixed (was: Started)
Thank you. IIUC this can now be closed.

Sign in to add a comment