NTPHomeTestCase/testOmniboxWidthRotation and NTPHomeTestCase/testOmniboxWidthRotationBehindSettings are failing on iPhoneX due to some width check. https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/32805 Failure is caused by CL https://chromium-review.googlesource.com/737995
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26054fded2ff114df520b5ed2714c1673030b54d commit 26054fded2ff114df520b5ed2714c1673030b54d Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Oct 30 14:37:22 2017 Reland "Fix iPhone X collections issues" As MDC is rolled to 38.0, we can start taking advantage of the fix included for the iPhone X by letting the collection have the default adjustedContentBehavior. This also changes the NTP to use an automatic adjustedContentInsetBehavior, to prevent a bug with the overscroll action. Bug: 767802 , 779234 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9d4b3c2cbe7feedcab03714c061a8ff9705d4d57 Reviewed-on: https://chromium-review.googlesource.com/743018 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#512491} [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/collection_view/collection_view_controller.mm [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm [modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98265d437faee582fdf7ab227f5ff39eff7d4249 commit 98265d437faee582fdf7ab227f5ff39eff7d4249 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Nov 06 23:44:08 2017 Reland "Fix iPhone X collections issues" As MDC is rolled to 38.0, we can start taking advantage of the fix included for the iPhone X by letting the collection have the default adjustedContentBehavior. This also changes the NTP to use an automatic adjustedContentInsetBehavior, to prevent a bug with the overscroll action. Bug: 767802 , 779234 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9d4b3c2cbe7feedcab03714c061a8ff9705d4d57 Reviewed-on: https://chromium-review.googlesource.com/743018 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#512491}(cherry picked from commit 26054fded2ff114df520b5ed2714c1673030b54d) Reviewed-on: https://chromium-review.googlesource.com/752461 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#402} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/collection_view/collection_view_controller.mm [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm [modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
Comment 1 by bugdroid1@chromium.org
, Oct 30 2017