New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 779228 link

Starred by 1 user
Status: Fixed
Owner:
█ mariakho...@chromium.org
Left Chrome team
Closed: Nov 2017
Cc:
█ awdf@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Failures in org.chromium.chrome.browser.notifications.CustomNotificationBuilderTest on Android O

Project Member Reported by mariakho...@chromium.org, Oct 27 2017 
On Android O, it seems that the large icon may be generated differently as we see the following test failures

org.chromium.chrome.browser.notifications.CustomNotificationBuilderTest#testGeneratesLargeIconFromOriginWhenLargeIconProvidedIsNull consistently fails (locally reproducible)

C   33.365s Main  java.lang.AssertionError
C   33.365s Main  	at org.junit.Assert.fail(Assert.java:86)
C   33.365s Main  	at org.junit.Assert.assertTrue(Assert.java:41)
C   33.365s Main  	at org.junit.Assert.assertTrue(Assert.java:52)
C   33.365s Main  	at org.chromium.chrome.browser.notifications.CustomNotificationBuilderTest.assertLargeNotificationIconAsExpected(CustomNotificationBuilderTest.java:354)
C   33.365s Main  	at org.chromium.chrome.browser.notifications.CustomNotificationBuilderTest.testGeneratesLargeIconFromOriginWhenLargeIconProvidedIsNull(CustomNotificationBuilderTest.java:319)



org.chromium.chrome.browser.notifications.CustomNotificationBuilderTest#testGeneratesLargeIconFromOriginWhenNoLargeIconProvided

I  381.128s run_tests_on_device(FA6AB0304025)    	at org.junit.Assert.fail(Assert.java:86)
I  381.128s run_tests_on_device(FA6AB0304025)    	at org.junit.Assert.assertTrue(Assert.java:41)
I  381.128s run_tests_on_device(FA6AB0304025)    	at org.junit.Assert.assertTrue(Assert.java:52)
I  381.128s run_tests_on_device(FA6AB0304025)    	at org.chromium.chrome.browser.notifications.CustomNotificationBuilderTest.assertLargeNotificationIconAsExpected(CustomNotificationBuilderTest.java:354)
I  381.128s run_tests_on_device(FA6AB0304025)    	at org.chromium.chrome.browser.notifications.CustomNotificationBuilderTest.testGeneratesLargeIconFromOriginWhenNoLargeIconProvided(CustomNotificationBuilderTest.java:301)

Comment 1 by awdf@chromium.org, Oct 30 2017

Components: UI>Notifications

Comment 2 by awdf@chromium.org, Oct 30 2017 

Given we don't use the CustomNotificationBuilder on O, we use the StandardNotificationBuilder on N+, unless the user changes a chrome://flag, we could just disable these tests on N/O+

Comment 3 by peter@chromium.org, Oct 30 2017 

Can we just remove the chrome://flags entry on modern versions too? It's completely untested.

Comment 4 by mariakho...@chromium.org, Oct 30 2017 

Having tests representative of what happens on the platform SGTM.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30f135a3ce449c002f9dd7cba7486076fb55d62e

commit 30f135a3ce449c002f9dd7cba7486076fb55d62e
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Mon Nov 20 18:37:58 2017

Disable CustomNotificationBuilderTest on N+.

CustomNotificationBuilder is not used on N+.
BUG= 779228 

Change-Id: Ic8bf59e6b6e2d58306dbb53eb26a26f878e9b4e8
Reviewed-on: https://chromium-review.googlesource.com/777420
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517867}
[modify] https://crrev.com/30f135a3ce449c002f9dd7cba7486076fb55d62e/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilderTest.java

Comment 6 by mariakho...@chromium.org, Nov 20 2017

Cc: awdf@chromium.org
Owner: mariakho...@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment