New issue
Advanced search Search tips

Issue 779221 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 791654
issue 792233
issue 810535

Blocking:
issue 776464



Sign in to add a comment

Create mojom::WallpaperControllerClient and modify mojom::WallpaperController

Project Member Reported by wzang@chromium.org, Oct 27 2017

Issue description

Add all the methods called directly by Chrome clients (wallpaper picker, login screen etc.) into the mojom::WallpaperController interface. Pass all the Chrome related info as a struct.

Avoid leaving anything behind in Chrome other than the WallpaperControllerClient itself, otherwise, it may grow into another 'WallpaperManager' that's out of control.

Rename WallpaperPicker interface to WallpaperControllerClient, to be consistent with other ash clients.
 

Comment 1 by wzang@chromium.org, Oct 27 2017

Blocking: 776464
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2394cf4be5e2a606dd0e039890501ee13abde787

commit 2394cf4be5e2a606dd0e039890501ee13abde787
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Nov 07 23:45:28 2017

Modify WallpaperManager interface as a prototype for Mojo interface

This is not the final version ready for the Mojo interface, but makes
the following modifications:

1) Make the distinction between 'set', 'show', and 'remove':
'set' must be called with a new image or file.
'show' is to actually display the wallpaper 'set' for this user before.
'remove' refers to the process of removing the custom wallpaper that
may be set earlier. When clients call 'RemoveUserWallpaperInfo', what
they need is to remove the wallpaper, so rename to RemoveWallpaper.

2) WallpaperInfo should be an internal concept. Make the related
methods private.

3) 'ShowSigninWallpaper' is a new method. Although the concept of
sign-in wallpaper is not new. It's reasonable to separate it from
ShowUserWallpaper because it's a different use case.

TBR=oshima@chromium.org, alemate@chromium.org

Bug:  779221 
Change-Id: I6e3ecfcde3e74f0aa5ce2b3387253f73c316df2d
Reviewed-on: https://chromium-review.googlesource.com/734329
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514653}
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/login/ui/user_adding_screen.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/login/ui/webui_login_display.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/ui/ash/lock_screen_client.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231

commit 1d9c2207f36d9ac3b309e1f01eb1abf4f2371231
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Nov 18 01:08:03 2017

cros: Create WallpaperControllerClient to replace WallpaperManager

The functions listed in the mojo interface are all from
WallpaperManager. The next step is to move their implementation to
//ash one by one. By the time they are all moved, WallpaperManager
can basically be deleted.

TBR=michaelpg@chromium.org

Bug:  779221 
Change-Id: I90efac15662d32d96670f56af3145a9c42270ef3
Reviewed-on: https://chromium-review.googlesource.com/762126
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517655}
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/ash/shelf/shelf_context_menu_model_unittest.cc
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/ui/ash/test_wallpaper_controller.cc
[add] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/ui/ash/test_wallpaper_controller.h
[add] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/ui/ash/wallpaper_controller_client.cc
[add] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/ui/ash/wallpaper_controller_client.h
[add] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/ui/ash/wallpaper_controller_client_unittest.cc
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/browser/ui/webui/settings/appearance_handler.cc
[modify] https://crrev.com/1d9c2207f36d9ac3b309e1f01eb1abf4f2371231/chrome/test/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd94d92eab863ebd845e8fd7c06fe06346f617f1

commit dd94d92eab863ebd845e8fd7c06fe06346f617f1
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Dec 02 02:41:24 2017

wallpaper refactoring: Move SetOnlineWallpaper to WallpaperController

Migrate |SetOnlineWallpaper| (used by wallpaper picker) to
WallpaperController.

The goal of the CL:

1) Make sure not to introduce regression in |WallpaperManager| under
Config::CLASSIC. (Have to use some 'hacks' within |WallpaperManager| to
avoid forking the code.)

2) MASH does not crash when setting wallpaper, but it won't be able
to save wallpaper. The wallpaper newly set during an active session
will be lost when the session ends.

TBR=brettw@chromium.org

Bug:  779221 
Change-Id: I7b6f1d1d95a8a4b0ad20d31bc4dcc957207f246e
Reviewed-on: https://chromium-review.googlesource.com/770711
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521186}
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/ash/shell.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service_unittest.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/dd94d92eab863ebd845e8fd7c06fe06346f617f1/components/wallpaper/wallpaper_info.h

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18f0647a582aa0f919df8bd2270d42f37ccef7bd

commit 18f0647a582aa0f919df8bd2270d42f37ccef7bd
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Dec 02 09:54:20 2017

wallpaper refactoring: Move RemoveUserWallpaper to WallpaperController

All the temporary code have been explicitly marked as TODO. Those
without the mark is the 'permanent' code.

1) Replace RemoveUserWallpaper with a mojo call via
   |WallpaperControllerClient|.

2) Add additional directory paths in |SetClient| and rename it to
   |SetClientAndPaths|.

3) Add additional unit tests for |WallpaperController|.

TBR=jdufault@chromium.org

Bug:  779221 
Change-Id: Ife3bc79b4c353ed9d7e6e0332a9bf048cef3bbf6
Reviewed-on: https://chromium-review.googlesource.com/776216
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521208}
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/ash/shelf/shelf_context_menu_model_unittest.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service_unittest.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/login/users/user_manager_unittest.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_unittest.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/ui/ash/test_wallpaper_controller.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/ui/ash/test_wallpaper_controller.h
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/ui/ash/wallpaper_controller_client.cc
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/ui/ash/wallpaper_controller_client.h
[modify] https://crrev.com/18f0647a582aa0f919df8bd2270d42f37ccef7bd/chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc

Comment 6 by x...@chromium.org, Dec 4 2017

Blockedon: 791654

Comment 7 by wzang@chromium.org, Dec 5 2017

Blockedon: 792233
Components: UI>Shell>Wallpaper
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92b2329448dd4b2a1edfd451da707cebbb7c48c

commit c92b2329448dd4b2a1edfd451da707cebbb7c48c
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Dec 21 03:18:09 2017

wallpaper refactoring: Move SetCustomWallpaper to WallpaperController

|IsPendingWallpaper()| returns false in three cases: 1) Kiosk mode is
on, 2) Policy is enforced. 3) |show_wallpaper| is false. The first two
cases are now checked by |CanSetCustomWallpaper()|, and case 3) is
the same with |account_id.is_active|.

The check of |CanSetCustomWallpaper()| does not work under MASH. It's
listed as TODO. (Lots of code in arc_wallpaper_service.cc depends on
wallpaper controller observer, so it's actually not working with MASH
right now.)

In addition, after the refactoring, SetCustomWallpaper does not go
through PendingWallpaper any more (PendingWallpaper is only useful
for |ShowWallpaper()|, not custom wallpapers). So there is no need to
keep |IsPendingWallpaper()|.

TBR=oshima@chromium.org

Bug:  779221 
Change-Id: I9527d20bb823581d4b380354764d0df10862bcce
Reviewed-on: https://chromium-review.googlesource.com/812326
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525578}
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/chrome/browser/ui/ash/test_wallpaper_controller.cc
[modify] https://crrev.com/c92b2329448dd4b2a1edfd451da707cebbb7c48c/chrome/browser/ui/ash/test_wallpaper_controller.h

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75

commit 8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Dec 22 04:56:14 2017

wallpaper refactoring: Move ShowWallpaper to WallpaperController

1) Migrated everything related to ShowWallpaper except for device
   policy wallpaper. Therefore the WallpaperManager::ShowWallpaper
   method is still kept but it's trivial to completely remove it later.

2) Delete PendingWallpaper. In the unlikely case that it turns out to
   be useful, we can add it back.

3) Deleted the tests which have been disabled for a long time in
   wallpaper_manager_browsertest.cc. Left a TODO for
   |WallpaperControllerTest.ShowCustomWallpaperWithCorrectResolution|
   since it depends on UpdateWallpaper() to be migrated.

TBR=brettw@chromium.org

Bug:  779221 
Change-Id: I888e1619c6670912588c940b329f89b335770ad2
Reviewed-on: https://chromium-review.googlesource.com/821455
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525933}
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/ash/wallpaper/wallpaper_decoder.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service_unittest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.h
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/profiles/profile_manager_unittest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/8cf7ebd3756dd3e63838b358f96d31ccaa8f1e75/chrome/browser/ui/browser_finder_chromeos_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b0df8de3bc9762b900dcff3c517a131388b599

commit 57b0df8de3bc9762b900dcff3c517a131388b599
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Jan 03 09:03:48 2018

wallpaper refactoring: Delete UpdateWallpaper in WallpaperDelegate

Previously, UpdateWallpaper() is needed in the WallpaperDelegate
interface because it relies on Chrome to set the correct image. After
everything is migrated, it no longer needs to call into Chrome.
(Eventually WallpaperDelegate will be deleted as well.)

All the tests in |wallpaper_manager_browsertest.cc| have been migrated
(some of them are deleted because they have been disabled for a long
time). But there is some untested code path in wallpaper_manager and
we'll add more tests in follow-up CLs.

TBR=oshima@chromium.org

Bug:  779221 ,  794725 
Change-Id: I81b0a0b6b2a96423a1191054e154761b10304382
Reviewed-on: https://chromium-review.googlesource.com/826325
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526654}
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/default_wallpaper_delegate.cc
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/default_wallpaper_delegate.h
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/wallpaper/test_wallpaper_delegate.cc
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/wallpaper/test_wallpaper_delegate.h
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/wallpaper/wallpaper_delegate.h
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/wallpaper/wallpaper_delegate_mus.cc
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/ash/wallpaper/wallpaper_delegate_mus.h
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/chrome/browser/chromeos/background/ash_wallpaper_delegate.cc
[delete] https://crrev.com/5ac59e663d764a3257c8a038a364d4cd578b4ef4/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/57b0df8de3bc9762b900dcff3c517a131388b599/chrome/test/BUILD.gn

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5340c56847c550c57c347a4383bfcf9d1e0f39b

commit d5340c56847c550c57c347a4383bfcf9d1e0f39b
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jan 04 18:42:10 2018

wallpaper refactoring: Add UpdateCustomWallpaperLayout method

Created |UpdateCustomWallpaperLayout| so that |SetWallpaperInfo| is
made private. Also, WallpaperManager::UpdateWallpaper can be deprecated
due to this CL and the previous CL.

Bug:  779221 
Change-Id: I27ec8095e0ca21eee8bea3216b930d9bef9e4f4e
Reviewed-on: https://chromium-review.googlesource.com/828696
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527045}
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/chrome/browser/ui/ash/test_wallpaper_controller.cc
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/chrome/browser/ui/ash/test_wallpaper_controller.h
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/chrome/browser/ui/ash/wallpaper_controller_client.cc
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/chrome/browser/ui/ash/wallpaper_controller_client.h
[modify] https://crrev.com/d5340c56847c550c57c347a4383bfcf9d1e0f39b/chrome/test/data/extensions/api_test/wallpaper_manager/test.js

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6925317dbbbf3914c8018df61f8b6ed4e08dd15d

commit 6925317dbbbf3914c8018df61f8b6ed4e08dd15d
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jan 04 19:58:22 2018

wallpaper refactoring: SetCustomizedDefaultWallpaper

1) Moved the wallpaper_manager.cc code that's only used by customized
   default wallpapers to a separate file under
   //chrome/browser/chromeos/customization. That should be a better
   place than ash/wallpaper.

2) customization_wallpaper_downloader_browsertest.cc already tests this
   code path.

3) Deprecate the |CustomizedWallpaperRescaledFiles| class for
   simplicity.

4) Changed the API to SetCustomizedWallpaperPaths that only sends paths
   instead of images. Previously, several places that called the method
   had to supply empty images as placeholders.

Bug:  779221 
Change-Id: Ia8d38b25444a1a04e81cd39eb3c553ae14e7d4a1
Reviewed-on: https://chromium-review.googlesource.com/831386
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527075}
[modify] https://crrev.com/6925317dbbbf3914c8018df61f8b6ed4e08dd15d/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/6925317dbbbf3914c8018df61f8b6ed4e08dd15d/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/6925317dbbbf3914c8018df61f8b6ed4e08dd15d/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/6925317dbbbf3914c8018df61f8b6ed4e08dd15d/chrome/browser/chromeos/customization/customization_document.cc
[add] https://crrev.com/6925317dbbbf3914c8018df61f8b6ed4e08dd15d/chrome/browser/chromeos/customization/customization_wallpaper_util.cc
[add] https://crrev.com/6925317dbbbf3914c8018df61f8b6ed4e08dd15d/chrome/browser/chromeos/customization/customization_wallpaper_util.h
[modify] https://crrev.com/6925317dbbbf3914c8018df61f8b6ed4e08dd15d/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/6925317dbbbf3914c8018df61f8b6ed4e08dd15d/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee8bd341e805002f543357ea2b79051123eab4f3

commit ee8bd341e805002f543357ea2b79051123eab4f3
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Jan 23 19:32:49 2018

wallpaper refactoring: Reimplement SetPolicyWallpaper

A few differences with the current implementation:

1) Currently there're both |WallpaperManager::OnPolicySet| and
   |OnPolicyFetched|. |OnPolicySet| merely labels the wallpaper
   as POLICY type to prevent potential wallpaper changes. This results
   in a temporary inconsistency between the actual wallpaper and its
   type. In this version this method is deleted. (ie, if policy fetch
   never succeeds, WallpaperController won't know about the policy.)

2) Currently |OnPolicyCleared| only sets the type back to DEFAULT
   without deleting the policy wallpaper file. This doesn't result in
   visible bugs, but it's better to delete the files and explicitly
   calls SetDefaultWallpaper for this user.

3) The existing tests in wallpaper_manager_policy_browsertest.cc stay
   unchanged in this CL. But they may be moved to a different place
   later.

Test: Verified on Admin console, no conflict with device policy.
Bug:  779221 ,  800182 
Change-Id: Ibb3fa38ddc19b095bfd684fe2fa6e500d7a580b4
Reviewed-on: https://chromium-review.googlesource.com/845262
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531301}
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/ash/wallpaper/wallpaper_decoder.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/ash/wallpaper/wallpaper_decoder.h
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/chromeos/login/users/user_manager_unittest.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/ui/ash/test_wallpaper_controller.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/ui/ash/test_wallpaper_controller.h
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/ui/ash/wallpaper_controller_client.cc
[modify] https://crrev.com/ee8bd341e805002f543357ea2b79051123eab4f3/chrome/browser/ui/ash/wallpaper_controller_client.h

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32df00de25fde74096aa40f892689d836cd8269e

commit 32df00de25fde74096aa40f892689d836cd8269e
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Feb 02 21:12:10 2018

wallpaper refactoring: Switch to ShowUserWallpaper in //ash

The implementation of ShowUserWallpaper has been fully moved to //ash.

TBR=alemate@chromium.org, oshima@chromium.org

Bug:  779221 
Test: ash_unittests, manual
Change-Id: I3c8de532228669baf56e336ad91c467407cfd9e5
Reviewed-on: https://chromium-review.googlesource.com/848311
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534150}
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/chromeos/login/ui/login_display_host.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/chromeos/login/ui/login_display_webui.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/chromeos/login/ui/user_adding_screen.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/32df00de25fde74096aa40f892689d836cd8269e/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36803252639e54e19af99e8a521697b62559341f

commit 36803252639e54e19af99e8a521697b62559341f
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Feb 08 01:54:31 2018

cros: Move InitializeWallpaper to WallpaperControllerClient

We should be able to deprecate InitializeWallpaper after views-based
login is enabled: the call sites should request the wallpaper at login
screen or after chrome restart. Currently, both InitializeWallpaper and
the call sites request the same wallpaper resulting in duplicate logic.

InitializeWallpaper is still useful at login screen because the web-ui
has a delay in loading, so InitializeWallpaper will first show a
wallpaper to fill the gap. But the views-based login should be fast
enough so InitializeWallpaper is unncessary.

      policy wallpaper

Bug:  779221 
Test: On device, login screen startup and browser restart, w/o device
Change-Id: I12afd7f3b635a08d49ae1693734f5f42102b20a1
Reviewed-on: https://chromium-review.googlesource.com/851912
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535250}
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/default_wallpaper_delegate.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/default_wallpaper_delegate.h
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/shelf/shelf_context_menu_model_unittest.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/wallpaper/wallpaper_delegate.h
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/wallpaper/wallpaper_delegate_mus.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/ash/wallpaper/wallpaper_delegate_mus.h
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/chromeos/background/ash_wallpaper_delegate.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/chromeos/customization/customization_wallpaper_util.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/ui/ash/test_wallpaper_controller.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/ui/ash/test_wallpaper_controller.h
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/ui/ash/wallpaper_controller_client.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/ui/ash/wallpaper_controller_client.h
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/ui/ash/wallpaper_policy_handler.cc
[modify] https://crrev.com/36803252639e54e19af99e8a521697b62559341f/chrome/browser/ui/ash/wallpaper_policy_handler.h

Blockedon: 810535
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45db4d022a57c54f5f2ae40a7a95f314c56ef099

commit 45db4d022a57c54f5f2ae40a7a95f314c56ef099
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Feb 22 23:10:32 2018

cros: Move |ShouldShowInitialAnimation| to WallpaperController

We can completely deprecate the WallpaperDelegate interface after this
CL.

Created |OnFirstWallpaperAnimationFinished| to support a code path in
web-ui login. We should be able to delete it after views-based login is
enabled.

Bug:  779221 
Test: ash_unittests, on device
Change-Id: I330994681e2e9c1917ab86d6e9c7fda136115608
Reviewed-on: https://chromium-review.googlesource.com/854939
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538609}
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/default_wallpaper_delegate.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/default_wallpaper_delegate.h
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/root_window_controller.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/shelf/shelf_context_menu_model_unittest.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/wallpaper/wallpaper_delegate.h
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/wallpaper/wallpaper_delegate_mus.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/wallpaper/wallpaper_delegate_mus.h
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/ash/wallpaper/wallpaper_widget_controller.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/chrome/browser/chromeos/background/ash_wallpaper_delegate.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/chrome/browser/ui/ash/wallpaper_controller_client.cc
[modify] https://crrev.com/45db4d022a57c54f5f2ae40a7a95f314c56ef099/chrome/browser/ui/ash/wallpaper_controller_client.h

Comment 20 by wzang@chromium.org, Feb 22 2018

Status: Fixed (was: Assigned)

Sign in to add a comment