DexLoaderTests failing on Android M+ |
||||
Issue descriptionSeveral test cases in DexLoaderTest is failing on Android O. Please take a look as we're trying to get the tests green on Android O -- these are reproducible locally. org.chromium.webapk.shell_apk.DexLoaderTest#testPreviouslyLoadedFromLocalDataDir: C 42.541s Main [FAIL] org.chromium.webapk.shell_apk.DexLoaderTest#testPreviouslyLoadedFromLocalDataDir: C 42.541s Main java.lang.AssertionError C 42.541s Main at org.junit.Assert.fail(Assert.java:86) C 42.541s Main at org.junit.Assert.assertTrue(Assert.java:41) C 42.541s Main at org.junit.Assert.assertTrue(Assert.java:52) C 42.541s Main at org.chromium.webapk.shell_apk.DexLoaderTest.testPreviouslyLoadedFromLocalDataDir(DexLoaderTest.java:237 Fails on the assertion that no files are modified on re-load, the modified file is canary.dex.arm.flock. ------ org.chromium.webapk.shell_apk.DexLoaderTest#testLoadFromRemoteDataDir I 31.673s run_tests_on_device(008dab7c49d9420a) 1) testLoadFromRemoteDataDir(org.chromium.webapk.shell_apk.DexLoaderTest) I 31.673s run_tests_on_device(008dab7c49d9420a) java.lang.AssertionError: Could not extract and optimize dex. I 31.673s run_tests_on_device(008dab7c49d9420a) at org.junit.Assert.fail(Assert.java:88) I 31.673s run_tests_on_device(008dab7c49d9420a) at org.chromium.webapk.shell_apk.DexLoaderTest.testLoadFromRemoteDataDir(DexLoaderTest.java:153) 10-27 14:09:18.079 21393 21405 I zygote64: The ClassLoaderContext is a special shared library. 10-27 14:09:18.085 21393 21405 E cr_DexOptimzer: Failed to create dex. ------------------------------------------ org.chromium.webapk.shell_apk.DexLoaderTest#testLoadFromLocalDataDir C 48.818s Main java.lang.AssertionError: expected:<2> but was:<3> C 48.818s Main at org.junit.Assert.fail(Assert.java:88) C 48.818s Main at org.junit.Assert.failNotEquals(Assert.java:834) C 48.818s Main at org.junit.Assert.assertEquals(Assert.java:645) C 48.818s Main at org.junit.Assert.assertEquals(Assert.java:631) C 48.819s Main at org.chromium.webapk.shell_apk.DexLoaderTest.testLoadFromLocalDataDir(DexLoaderTest.java:189)
,
Nov 20 2017
,
Nov 21 2017
I will look into these tests this week
,
Nov 27 2017
Didn't get to this last week. I will look into it this week. The test failure indicates an actual bug. Currently, WebAPKs can't load the dex file stored in Chrome's data directory without moving the dex file to the WebAPK's data directory first. To fix this, I need to trace through Android Java code
,
Dec 7 2017
Any updates here?
,
Dec 8 2017
Given that we haven't made progress on this yet, I think we should just disable the test for O for now
,
Feb 20 2018
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1f6822a0399bc32e5604a376e026383f6499c5e commit e1f6822a0399bc32e5604a376e026383f6499c5e Author: Donn Denman <donnd@google.com> Date: Wed Feb 21 02:03:27 2018 Disable testPreviouslyLoadedFromLocalDataDir on O. Disables DexLoaderTest#testPreviouslyLoadedFromLocalDataDir on Android-Oreo. BUG=779218 Change-Id: I6ee314f58cc0c0f8f28a010e525185399899a551 Reviewed-on: https://chromium-review.googlesource.com/927688 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#537992} [modify] https://crrev.com/e1f6822a0399bc32e5604a376e026383f6499c5e/chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java
,
Mar 1 2018
,
Mar 8 2018
testLoadFromRemoteDataDir is failing on M (and presumably above), too.
,
Mar 8 2018
jbudorick@: Do you have a link for the Android M failure? |
||||
►
Sign in to add a comment |
||||
Comment 1 by mariakho...@chromium.org
, Nov 15 2017