New issue
Advanced search Search tips

Issue 779217 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 769401



Sign in to add a comment

The NetworkContext is not created when the network service is enabled when running HotwordInstallerBrowserTest.AbortInstallOnShutdown

Project Member Reported by juncai@chromium.org, Oct 27 2017

Issue description

When running the following browser tests:
HotwordInstallerBrowserTest.AbortInstallOnShutdown
SpellingMenuObserverTest.SuggestionsForceTopSeparator
using "--enable-features=NetworkService" flag, they fail at:
DCHECK(!base::FeatureList::IsEnabled(features::kNetworkService)) in StoragePartitionImpl::GetNetworkContext().
 

Comment 1 by juncai@chromium.org, Oct 27 2017

Description: Show this description

Comment 2 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 3 by juncai@chromium.org, Mar 16 2018

Cc: -juncai@chromium.org
Owner: juncai@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a758564e3eecfea404a9dea588cf025ed242c28e

commit a758564e3eecfea404a9dea588cf025ed242c28e
Author: Jun Cai <juncai@chromium.org>
Date: Fri Mar 23 18:23:58 2018

Network Service: Fix SpellingMenuObserverTest.SuggestionsForceTopSeparator

This CL fixes SpellingMenuObserverTest.SuggestionsForceTopSeparator by
implementing TestingProfile::CreateMainNetworkContext() for network
service.

Bug:  779217 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib5c134c401a66feed97faf41d9e0b17b6ed2badf
Reviewed-on: https://chromium-review.googlesource.com/963402
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545523}
[modify] https://crrev.com/a758564e3eecfea404a9dea588cf025ed242c28e/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/a758564e3eecfea404a9dea588cf025ed242c28e/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 5 by juncai@chromium.org, Mar 23 2018

Status: Fixed (was: Started)

Sign in to add a comment