NOTREACHED() reached at SaveFileManager::OnSaveURL() when running SavePageBrowserTest.SavePageBrowserTest_NonMHTML |
||||||
Issue descriptionWhen running SavePageBrowserTest.SavePageBrowserTest_NonMHTML browser test using "--enable-features=NetworkService" flag, it fails at: NOTREACHED() at SaveFileManager::OnSaveURL().
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Jan 29 2018
FYI, the comment immediately above the NOTREACHED() is about ~11 years old and a wee bit out of date. - "save manager" probably refers to the SaveFileManager. This code used to live elsewhere. - GURL::SchemeIsStandard refers to GURL::IsStandard(). But then I can't find a call to IsStandard() in SaveFileManager anymore.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf commit 60a313da6edaa2b94a8a8dafa8501e41bec4eeaf Author: Jay Civelli <jcivelli@google.com> Date: Fri Mar 02 21:53:56 2018 Change Save Page to use the network service Making the Save Page code use the URLLoaderFactory instead of using the ResourceDispatcherHost directly. This means the resource downloads are triggered on the UI thread and download notifications also happen on the UI thread. Also removing a NOTREACHED in SimpleURLLoader::OnReceiveCachedMetadata that got hit when downloading some pages and is a valid call that we can ignore. Bug: 816644 , 779210 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3c4be94b253392ae6860f8c9e3f1e4fbb752b238 Reviewed-on: https://chromium-review.googlesource.com/944906 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540645} [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/content/browser/BUILD.gn [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/content/browser/download/save_file.h [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/content/browser/download/save_file_manager.cc [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/content/browser/download/save_file_manager.h [delete] https://crrev.com/7f738657cf5049ba6205b56d9b64b8e34405cd30/content/browser/download/save_file_resource_handler.cc [delete] https://crrev.com/7f738657cf5049ba6205b56d9b64b8e34405cd30/content/browser/download/save_file_resource_handler.h [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/content/browser/download/save_package.cc [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/content/browser/download/save_package.h [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/content/browser/download/save_types.cc [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/content/browser/download/save_types.h [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/services/network/public/cpp/simple_url_loader.cc [modify] https://crrev.com/60a313da6edaa2b94a8a8dafa8501e41bec4eeaf/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Mar 2 2018
,
Mar 2 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mmenke@chromium.org
, Nov 1 2017