Issue 779186 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	jamescook@chromium.org
Closed:	Nov 2017
Cc:	█ e...@chromium.org mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
Proj-Mustash-Mash

Extract a ShellPortMus from ShellPortMash

Project Member Reported by jamescook@chromium.org, Oct 27 2017

Issue description

Right now it handles both cases, and there's lots of "if (config == MUS) DoMus() else DoMash()". There are also mus_state_ and mash_state_ members. This leads to some bugs around accelerator controller and its delegate.

Just split the ShellPort subclasses into ShellPortClassic, ShellPortMus and ShellPortMash.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d788f5fbb93f88745867ecb1253f5c260261b8c

commit 3d788f5fbb93f88745867ecb1253f5c260261b8c
Author: James Cook <jamescook@chromium.org>
Date: Sat Oct 28 00:07:54 2017

cros: Split ShellPortMash into Mus and Mash subclasses

ShellPortMash is a mix of --mus and --mash support code.
Split it into two parts to make it easier to reason about
which code runs in which mode.

TBR=msw@chromium.org

Bug:  779186 
Test: ash_unittests, chrome --mus and chrome --mash
Change-Id: Ia6bfaf8e30826855d994e6604c244d68ffe086f5
Reviewed-on: https://chromium-review.googlesource.com/742130
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512360}
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/mus/BUILD.gn
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/mus/DEPS
[delete] https://crrev.com/8219cd5474c893b9105825b2cf59971ad996997d/ash/mus/bridge/DEPS
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/mus/bridge/shell_port_mash.h
[delete] https://crrev.com/8219cd5474c893b9105825b2cf59971ad996997d/ash/mus/bridge/shell_port_mash_test_api.h
[add] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/mus/shell_port_mus.cc
[add] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/mus/shell_port_mus.h
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/mus/window_manager.cc
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/shell_port.h
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/shell_port_classic.cc
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/ash/test/ash_test_helper.cc
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/chrome/browser/ui/DEPS
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/3d788f5fbb93f88745867ecb1253f5c260261b8c/chrome/browser/ui/browser_commands_chromeos.cc