New issue
Advanced search Search tips

Issue 779180 link

Starred by 1 user
Status: Verified
Owner:
yuweih@chromium.org
Closed: Oct 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Crash when disconnected remotely on iOS 9

Project Member Reported by yuweih@chromium.org, Oct 27 2017 
App Version: 64.0.3251.0
OS: iOS 9

What steps will reproduce the problem?
(1) Connect to a host w/o curtain mode
(2) Disconnect from the host side

What is the expected result?

Session successfully disconnected.

What happens instead?

App crashed.


Looks like this bug doesn't repro on iOS 11. We are soon dropping support for iOS 9 but we have no device to verify it on iOS 10. Better still investigate it.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a7bb5478b99b4eaba1b2685142b5ba90872d8e1

commit 2a7bb5478b99b4eaba1b2685142b5ba90872d8e1
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Oct 27 23:07:41 2017

[CRD iOS] Invalidate view size animation link when view will disappear

On older iOS version, when the session disconnects,
viewDidLayoutSubviews may still be called after viewWillDisappear is
called, which activates the view size animation link. This will crash
the app since it accesses _client.gestureInterpreter, which no longer
exists after the session is disconnected.

This CL fixes this by invalidating the view size animation link in
viewWillDisappear.

Bug:  779180 
Change-Id: If98e7f0b3e5917142fe0255b7a41d7ac505ede74
Reviewed-on: https://chromium-review.googlesource.com/742186
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512339}
[modify] https://crrev.com/2a7bb5478b99b4eaba1b2685142b5ba90872d8e1/remoting/ios/app/host_view_controller.mm

Comment 2 by yuweih@chromium.org, Oct 28 2017

Status: Fixed (was: Assigned)

Comment 3 by ajnolley@chromium.org, Nov 9 2017

Status: Verified (was: Fixed)
Verified Fixed in 34.0.3261.0
►

Sign in to add a comment