New issue
Advanced search Search tips

Issue 779160 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
juncai@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 769401



Sign in to add a comment

BrowserView::GetBrowserViewForBrowser(browser())->tabstrip()->new_tab_button()->new_tab_promo() is nullptr when running NewTabTrackerBrowserTest.TestShowPromo

Project Member Reported by juncai@chromium.org, Oct 27 2017 
When running
NewTabTrackerBrowserTest.TestShowPromo
browser test using "--enable-features=NetworkService" flag, it fails at:
EXPECT_TRUE(BrowserView::GetBrowserViewForBrowser(browser())
                  ->tabstrip()
                  ->new_tab_button()
                  ->new_tab_promo()
                  ->GetWidget()
                  ->IsVisible());
because BrowserView::GetBrowserViewForBrowser(browser())
                  ->tabstrip()
                  ->new_tab_button()
                  ->new_tab_promo()
is nullptr.

Comment 1 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 2 by thestig@chromium.org, Jan 25 2018 

Is this still a problem? I couldn't repro.

Comment 3 by juncai@chromium.org, Jan 25 2018 

I think this test case has been fixed and was removed from:
//testing/buildbot/filters/mojo.fyi.network_browser_tests.filter.
So this issue can be closed.

Comment 4 by juncai@chromium.org, Jan 25 2018

Status: Fixed (was: Available)
►

Sign in to add a comment