New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 779146 link

Starred by 1 user
Status: Fixed
Owner:
kjlubick@chromium.org
Closed: Nov 2017
Cc:
█ flowblok@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Show disabled buttons instead of hiding them

Project Member Reported by mar...@chromium.org, Oct 27 2017 
When a user is connected with an account with lower privilege, the Web UI hides functionality. The idea is to show it could be available but disabled so that the user is hinted that she can switch accounts to gain more functionality.

An hover text should call out something like "This account doesn't have access to this functionality, maybe you can switch to another one which has more access?"

Comment 1 by kjlubick@chromium.org, Nov 9 2017

Cc: -kjlubick@chromium.org
Owner: kjlubick@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/de3725141fdec5e98d19bb32c6b5517ee90a9c1c

commit de3725141fdec5e98d19bb32c6b5517ee90a9c1c
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Nov 09 18:45:34 2017

Disable buttons instead of hiding them on Swarming UI

Also migrate to using our custom style'd buttons instead
of paper-buttons, which don't like to display mouse-overs
when disabled.

Bug:  779146 
Change-Id: Id7dbeb2b327768f8f947e1f6fbdf01706b1bf75b
Reviewed-on: https://chromium-review.googlesource.com/760479
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/de3725141fdec5e98d19bb32c6b5517ee90a9c1c/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/de3725141fdec5e98d19bb32c6b5517ee90a9c1c/appengine/swarming/ui/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/de3725141fdec5e98d19bb32c6b5517ee90a9c1c/appengine/swarming/ui/res/imp/botlist/bot-list.html
[modify] https://crrev.com/de3725141fdec5e98d19bb32c6b5517ee90a9c1c/appengine/swarming/ui/res/imp/botlist/bot-mass-delete.html
[modify] https://crrev.com/de3725141fdec5e98d19bb32c6b5517ee90a9c1c/appengine/swarming/ui/res/imp/botpage/bot-page.html
[modify] https://crrev.com/de3725141fdec5e98d19bb32c6b5517ee90a9c1c/appengine/swarming/ui/res/imp/common/swarming-app.html
[modify] https://crrev.com/de3725141fdec5e98d19bb32c6b5517ee90a9c1c/appengine/swarming/ui/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/de3725141fdec5e98d19bb32c6b5517ee90a9c1c/appengine/swarming/ui/res/imp/tasklist/task-list.html
[modify] https://crrev.com/de3725141fdec5e98d19bb32c6b5517ee90a9c1c/appengine/swarming/ui/res/imp/taskpage/task-page.html

Comment 3 by kjlubick@google.com, Nov 9 2017

Status: Fixed (was: Started)
This is now live on chromium-swarm
►

Sign in to add a comment