New issue
Advanced search Search tips

Issue 779142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

DeviceStatusListener may stuck in online while it's offline.

Project Member Reported by xingliu@chromium.org, Oct 27 2017

Issue description

When network layer changes from online->offline->online or offline->online->offline, DSL may stuck in incorrect state.

This is due to we use a delay to signal offline->online, and if we immediately change back to offline, the delay callback will still run.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f05e55f9b3bfe0e29bc6de2b5c60c32e4f7028b8

commit f05e55f9b3bfe0e29bc6de2b5c60c32e4f7028b8
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Nov 02 00:38:49 2017

Download service: Fix network status signal cache.

When network layer changes from offline->online->offline,
DeviceStatusListener may stuck in incorrect state. Because we use a
delayed callback to signal offline->online, if we immediately change
back to offline, the delay callback will still run.


Bug:  779142 
Change-Id: Iede6830d5aa5d96818791f75a75f036724b72020
Reviewed-on: https://chromium-review.googlesource.com/741468
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513341}
[modify] https://crrev.com/f05e55f9b3bfe0e29bc6de2b5c60c32e4f7028b8/components/download/internal/scheduler/device_status_listener.cc
[modify] https://crrev.com/f05e55f9b3bfe0e29bc6de2b5c60c32e4f7028b8/components/download/internal/scheduler/device_status_listener.h
[modify] https://crrev.com/f05e55f9b3bfe0e29bc6de2b5c60c32e4f7028b8/components/download/internal/scheduler/device_status_listener_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment