New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779129 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

desktopui_MashLogin crash in arc::ArcVoiceInteractionFrameworkService::OnSessionStateChanged()

Project Member Reported by jamescook@chromium.org, Oct 27 2017

Issue description

On eve only. Started a few days ago. I'm not sure why we weren't seeing this before.

 1  chrome!arc::ArcVoiceInteractionFrameworkService::OnSessionStateChanged() [arc_voice_interaction_framework_service.cc : 360 + 0x5]
 2  chrome!session_manager::SessionManager::SetSessionState(session_manager::SessionState) [session_manager.cc : 42 + 0x5]
 3  chrome!chromeos::ChromeSessionManager::SessionStarted() [chrome_session_manager.cc : 217 + 0xd]
 4  chrome!chromeos::(anonymous namespace)::StartUserSession(Profile*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) [chrome_session_manager.cc : 124 + 0x6]
 5  chrome!chromeos::ChromeSessionManager::Initialize(base::CommandLine const&, Profile*, bool) [chrome_session_manager.cc : 0 + 0x5]
 6  chrome!chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() [chrome_browser_main_chromeos.cc : 1007 + 0x7]

It's probably the ash::Shell::Get() in this code:
  // TODO( crbug.com/757012 ): Avoid using ash::Shell here so that it can work in
  // mash.
  PrefService* prefs = Profile::FromBrowserContext(context_)->GetPrefs();
  bool enabled = prefs->GetBoolean(prefs::kVoiceInteractionEnabled);
  ash::Shell::Get()->NotifyVoiceInteractionEnabled(enabled);

updowndota's CL https://chromium-review.googlesource.com/c/chromium/src/+/734126 will fix the problem for real. I'm going to add an early-exit to get the build passing while that CL is in review.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb176c8f1aa05344ab6e39e18540237a9f939f2f

commit cb176c8f1aa05344ab6e39e18540237a9f939f2f
Author: James Cook <jamescook@chromium.org>
Date: Tue Oct 31 16:01:51 2017

cros: Fix crash in ArcVoiceInteractionFrameworkService on mash

The desktopui_MashLogin autotest is failing on eve. This code tries to
access ash::Shell from the browser process.  There's a real fix coming,
but for now just early exit before each Shell access to get the test
passing.

TBR=xiyuan@chromium.org

Bug:  757012 ,  779129 
Test: unit_tests, browser_tests --gtest_filter="Arc*" --mash
Change-Id: Ic20e890402705dd974195e5e8d1be959c5416a2f
Reviewed-on: https://chromium-review.googlesource.com/742045
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512842}
[modify] https://crrev.com/cb176c8f1aa05344ab6e39e18540237a9f939f2f/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc

Status: Fixed (was: Started)
More definitive fix coming in https://chromium-review.googlesource.com/c/chromium/src/+/734126

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment