New issue
Advanced search Search tips

Issue 779121 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 769401



Sign in to add a comment

The |url_chain_| contains one empty string when running DownloadTest.SaveLinkAsReferrerPolicyOrigin browser test

Project Member Reported by juncai@chromium.org, Oct 27 2017

Issue description

When runing
DownloadTest.SaveLinkAsReferrerPolicyOrigin
browser test using "--enable-features=NetworkService" flag, it fails at:
DCHECK(url.is_valid());
at V4ProtocolManagerUtil::CanonicalizeUrl() because the |url_chain_| contains one empty string at:
DownloadUrlSBClient::StartCheck()

 

Comment 1 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/697ab2676c85ca4295a2ce38b1ef901a7653729e

commit 697ab2676c85ca4295a2ce38b1ef901a7653729e
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Nov 09 19:15:15 2017

Clean up download browser tests.

This CL converts a few more tests to use embedded test server. Most of
them are not listed in the mojo filter but also not working correctly.


Change-Id: I02a9e0962a5b3efc61a3fbc05eb9df618c4fc1a7

Bug:  779121 ,  715630 
Change-Id: I02a9e0962a5b3efc61a3fbc05eb9df618c4fc1a7
Reviewed-on: https://chromium-review.googlesource.com/755839
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515233}
[modify] https://crrev.com/697ab2676c85ca4295a2ce38b1ef901a7653729e/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/697ab2676c85ca4295a2ce38b1ef901a7653729e/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 3 by dxie@chromium.org, May 17 2018

Status: Fixed (was: Available)

Sign in to add a comment