New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779120 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

innerWidth/innerHeight values inconsistent during page load

Reported by tapan.tr...@gmail.com, Oct 27 2017

Issue description

Device name: Any Mobile with chrome 61

Operating system: Any OS

URLs (if applicable):https://www.deltashares.com/products/sp-500/overview/ 

Steps to reproduce:
(1) Navigate to above url on mobile device with version 61 Image is not displayed.
(2)Navigate same url on mobile device with Chrome version 60 Image is visible.


Expected result: Image should get display on 61 as well...


Actual result:




 
Labels: Needs-triage-Mobile
Cc: msrchandra@chromium.org nyerramilli@chromium.org ligim...@chromium.org sandeepkumars@chromium.org
Components: UI
Labels: -Pri-3 Triaged-Mobile M-64 hasbisect-per-revision Pri-1 Type-Bug-Regression
Owner: bokan@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue in Android. Observed the image is not loading.

Steps Followed:
1. Launched Browser
2. Navigated to https://www.deltashares.com/products/sp-500/overview/ 
3. Observed the image is not loading.

Chrome versions tested:
61.0.3163.98, 64.0.3251.0

OS
Android 8.1.0

Android Devices
8.1.0; Pixel Build/OPM1.171019.004

Below is the bisect info
=======================

Chrome Good Build -- 61.0.3160.0
Chrome Bad Build  -- 61.0.3162.0

https://chromium.googlesource.com/chromium/src/+log/61.0.3160.0..61.0.3162.0?pretty=fuller&n=10000

Results from pre revision bisect --
You are looking for a change made after 488017(GOOD), but before 488018(BAD).
 
From the above revision range suspecting the following --
https://chromium.googlesource.com/chromium/src/+/6933fe8a1b1d14e0d36a69cb27ef026217595d95

@bokan -- Could you please look into the issue, kindly re-assign if this is not related to your changes.

Please navigate to below link for log's and video--
go/chrome-androidlogs/779120

Note: This issue is not observed in Desktop.

Thanks!!
Cc: cma...@chromium.org
Labels: ReleaseBlock-Stable
It would be good to have a fix, during M64 timeframe since this is a recent regression.

Comment 4 by bokan@chromium.org, Nov 3 2017

Thanks for pinging, I missed this. Will investigate it today.

Comment 5 by bokan@chromium.org, Nov 6 2017

Some investigative notes: this is in fact related to the inert-visual-viewport change pointed out above.

The page is reading window.innerWidth to determine whether to apply mobile/tablet/desktop styles during loading. We now use the layout viewport width, which is what the page actually wants to read in this case. The problem is that the layout viewport size is 980 until the viewport meta tag is read and we do a layout.

I think the underlying bug here is our arcane way of sizing the fixed container: issue 437303. Fixing that to match other browsers should also fix this. However, that might be difficult to do without impacting root-layer-scrolls ( issue 417782 ). I'll look into any mitigations that might be possible if that's the case.


Comment 6 by bokan@chromium.org, Nov 20 2017

Labels: -ReleaseBlock-Stable
Status: WontFix (was: Assigned)
Summary: innerWidth/innerHeight values inconsistent during page load (was: same image is getting displayed in lower version of chrome but not with chrome 61 on mobile view.)
The specific site appears to have been fixed.

Having taken a closer look, I actually think there isn't anything for us to do, this is expected behavior change from the inert-visual-viewport change. When script reads the values of window.innerWidth/innerHeight, it'll depend on whether it happens before or after the viewport <meta> tag is loaded. If the script reads before the <meta> tag is parsed (likely to be uncommon), it'll see 980px wide. Otherwise, it'll see whatever the <meta> tag specifies. I think this is rational though it does have some compat impact. I'll keep an eye out for similar issues but it doesn't seem to be common.

Sign in to add a comment