Fix touch screen calibrator for mus and mash |
||||||||
Issue descriptionForked from issue 734812 . These ash_unittests are disabled under mus and mash: -TouchCalibratorControllerTest.CustomCalibration -TouchCalibratorControllerTest.CustomCalibrationInvalidTouchId -TouchCalibratorControllerTest.TouchDeviceIdIsSet This is some sort of "calibrate your touchscreen" UI. It has an overlay view that lives in ash: https://cs.chromium.org/chromium/src/ash/display/touch_calibrator_view.h Sadrul mentioned that some of the calibration stuff should live in the ui service. I'm guessing stuff like this? Shell::Get()->display_manager()->SetTouchCalibrationData( target_display_.id(), pairs, display_size, touch_device_identifier);
,
Oct 30 2017
,
Oct 30 2017
James said he would look into this.
,
Oct 31 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f00f74feef559540a7ff68a7da56200b86ba7eea commit f00f74feef559540a7ff68a7da56200b86ba7eea Author: James Cook <jamescook@chromium.org> Date: Fri Nov 03 15:22:36 2017 cros: Fix TouchCalibrationController for --mus and --mash For go/mustash management of touchscreens under ozone is moving into the "mus" window server mojo service. When running chrome --mus (or chrome --mash) code in //ash cannot use DeviceDataManager, since it may live in another process. Convert TouchCalibrationController and its unit tests to use InputDeviceManager, which has an implementation that works with mus and mash. Re-enable the tests and clean up DEPS. Bug: 779118 Test: ash_unittests --mus and ash_unittests --mash Change-Id: I533f9ea4146f37d1173ddeb9d2c480c64d0b445c Reviewed-on: https://chromium-review.googlesource.com/748917 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#513783} [modify] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/ash/display/DEPS [modify] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/ash/display/touch_calibrator_controller.cc [modify] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/ash/display/touch_calibrator_controller_unittest.cc [modify] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/testing/buildbot/filters/ash_unittests_mash.filter [modify] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/testing/buildbot/filters/ash_unittests_mus.filter [modify] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/ui/display/BUILD.gn [modify] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/ui/display/manager/chromeos/touch_transform_controller.cc [modify] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/ui/display/manager/chromeos/touch_transform_controller.h [add] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/ui/display/manager/chromeos/touch_transform_controller_test_api.cc [add] https://crrev.com/f00f74feef559540a7ff68a7da56200b86ba7eea/ui/display/manager/chromeos/touch_transform_controller_test_api.h
,
Nov 3 2017
Verified that it works with a MIMO external touch display (like the GVC units) after turning on "enable-touchscreen-calibration" in about:flags.
,
Nov 3 2017
,
Jan 22 2018
,
Jan 23 2018
,
Feb 26 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sadrul@chromium.org
, Oct 27 2017