Milestone replacement tokenizer missing a space |
||
Issue descriptionhttps://chromium.googlesource.com/chromium/src/+blame/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#1388 We should have a single whitespace here: text = Common.UIString(' M<XX>'); ... because the regex that tokenizes to milestone consumes leading whitespace.
,
Oct 27 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/188528810d1d8d53432d8a642628f3832f8efc8e commit 188528810d1d8d53432d8a642628f3832f8efc8e Author: Eric Lawrence <elawrence@chromium.org> Date: Mon Oct 30 20:13:12 2017 Add space before Milestone token in Console message The code that coalesces multiple messages to a summary message lacked a space before the "M<XX>" string, but the regular expression that matches the input consumes a space, meaning that the replacement operation causes two words to run together. This CL adds a leading space to the replaced text. Bug: 779104 Change-Id: Id8399a584e2988755d46bd56402f3846fd59f49e Reviewed-on: https://chromium-review.googlesource.com/740979 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512591} [modify] https://crrev.com/188528810d1d8d53432d8a642628f3832f8efc8e/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
,
Dec 11 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by elawrence@chromium.org
, Oct 27 2017