New issue
Advanced search Search tips

Issue 779102 link

Starred by 1 user
Status: Fixed
Owner:
pbos@chromium.org
Closed: Nov 2017
Cc:
bsep@chromium.org
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

views::Checkbox checkbox is partially clipped under Harmony

Project Member Reported by pbos@chromium.org, Oct 27 2017 
Looks like the ink drop size isn't accounted for as the UseMd() branch doesn't update the image as it uses a separate child-view mechanism.

This is a bit hand-wavy until I've figured out how to fix it. :)
with-bounds.png
16.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c858650450f51cbff4a48689f9431b3b491d39e0

commit c858650450f51cbff4a48689f9431b3b491d39e0
Author: Peter Boström <pbos@chromium.org>
Date: Fri Nov 03 03:19:16 2017

Account for insets in LabelButton GetHeightForWidth().

Prevents the views::Checkbox checkbox icon from being cropped/clipped
under Harmony / UseMd().

Although the checkbox icon height used to be taken into account, the
insets that would surround it were not, causing the icon to end up
cropped.

Bug:  chromium:779102 
Change-Id: Ibdd6f08ca67af7861a4e1dae93251cc8c911adb2
Reviewed-on: https://chromium-review.googlesource.com/742324
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513664}
[modify] https://crrev.com/c858650450f51cbff4a48689f9431b3b491d39e0/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/c858650450f51cbff4a48689f9431b3b491d39e0/ui/views/controls/button/label_button.h
[modify] https://crrev.com/c858650450f51cbff4a48689f9431b3b491d39e0/ui/views/controls/button/label_button_unittest.cc

Comment 2 by pbos@chromium.org, Nov 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment