[WPT import] Check Blink trybot failure reason? |
|||
Issue descriptionNot exactly a bug, but rather something I'd like to discuss. https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/3962 was working fine, but the Mac build was broken when the mac*_blink_rel trybots were processing the import, which meant they didn't run the layout tests and the rebaselines were made only against Linux and Windows. Obviously, the final patch didn't work because it caused mac_chromium_rel_ng to go red. I wonder if we can and whether it makes sense to either cause the import to fail or retrigger the trybots when they fail for a reason that's not "layout tests not passing".
,
Oct 30 2017
Is that currently doable though? `git-cl try-results -- issue 740976 --gerrit -p 1 --json -' returns a JSON with the same value in the "failure_reason" field for both build failures and layout test failures, so it's not clear if we can use git-cl to determine how a build has failed.
,
Oct 30 2017
Yes let's get rid of that string concatenation then! The simpler, the merrier :)
,
Oct 30 2017
> Yes let's get rid of that string concatenation then! The simpler, the merrier :) That was supposed to have been sent to issue 755753 , right?
,
Oct 30 2017
Oops, yes. Sorry, working on a shuttle bus is harder than I imagined. :(
,
Oct 30
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 6
Ping qyearsley@chromium.org robertma@chromium.org for triage.
,
Nov 7
Looks like this is still a possible feature, but low-priority. |
|||
►
Sign in to add a comment |
|||
Comment 1 by qyears...@chromium.org
, Oct 30 2017