[Payments] Credit card save dialog shows a highlight on the button at CVC step |
|||||
Issue descriptionSee screenshot. Steps: Ensure that you are running a version later than 64.0.3248.0 (Mac ONLY) 1. Turn on chrome://flags#enable-autofill-credit-card-upload-cvc-prompt 2. Make sure you are signed in to Chrome. 3. Visit https://dump-truck.appspot.com/usecase-address_then_cc_text_no_cvc/ , Click “Start”, “Fill with Default Values”, “Submit”, “Fill with Default Values”, “Submit”. 4. A dialog should show up with the option to click "Next". When "Next" is clicked the button changes to "Confirm" but for a split second it appears like the attached screenshot.
,
Oct 27 2017
,
Nov 9 2017
To easily test this on ToT: out/Default/browser_tests --gtest_filter=BrowserDialogTest.Invoke --dialog=SaveCardBubbleControllerImplTest.InvokeDialog_Server_WithCvcStep --disable-features=SecondaryUiMd --interactive Note that with SecondaryUiMd enabled, this doesn't repro. We should confirm if this is only Mac or it affects Linux,Windows,CrOS.
,
Nov 17 2017
Adding Trent in case he has suggestions on this. It seems like UpdateDialogButtons (and subsequent layout) draws the new button incorrectly.
,
Nov 17 2017
I think this is the hover animation fading out over the old button size. Resizing the button doesn't cancel any running animations. It probably should. Note I couldn't repro until I disabled chrome://flags/#secondary-ui-md -- with chrome://flags/#secondary-ui-md, the buttons at the first step take a more consistent width due to some Harmony-specific layout logic. Of course.. we can't rely on the widths being consistent due to internationalisation issues -- If "No, thank you" is too long, the "Next" button won't stretch to match it.
,
May 1 2018
,
May 11 2018
CVC step was removed recently |
|||||
►
Sign in to add a comment |
|||||
Comment 1 Deleted