New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779075 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

network_service_browser_tests timeout on mojo_linux

Project Member Reported by qin...@chromium.org, Oct 27 2017

Issue description

Seeing lots of test failures/timeouts.
Possibly related to https://chromium-review.googlesource.com/738013.
Looks like those tests accidentally passes before that CL, and the CL exposes the actual failure.

will disable the failing tests today
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a6ddd571bb605a709398e7a8182f82db2474829

commit 6a6ddd571bb605a709398e7a8182f82db2474829
Author: Min Qin <qinmin@chromium.org>
Date: Fri Oct 27 17:13:35 2017

Disable all the browsertests that timed out on mojo_linux

all these individual timeouts caused the browser_tests to timeout
disable all of them

BUG= 779075 

Disable some content browsertests failing on mojo_linux

TBR=dtrainor@chromium.org

Change-Id: I476616f786fa8c65d06816f9c91e17a01a07fe56
Reviewed-on: https://chromium-review.googlesource.com/740865
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512219}
[modify] https://crrev.com/6a6ddd571bb605a709398e7a8182f82db2474829/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f6d45116bf6ef36aafcbcd5e681059d8f9be36b

commit 8f6d45116bf6ef36aafcbcd5e681059d8f9be36b
Author: Min Qin <qinmin@chromium.org>
Date: Fri Oct 27 21:23:59 2017

disable browser_tests on mojo_linux bot

Lots of tests timed out, disable the test suite
leaving the test filter file for now and will update it once we figure out all the timeout tests

BUG= 779075 
NOTRY=true
NOTREECHECKS=true

Change-Id: I29fe58f7d641c70b623656567475836cdda73121
Reviewed-on: https://chromium-review.googlesource.com/742140
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512297}
[modify] https://crrev.com/8f6d45116bf6ef36aafcbcd5e681059d8f9be36b/testing/buildbot/chromium.fyi.json

Comment 3 by jam@chromium.org, Oct 27 2017

Cc: yzshen@chromium.org

Comment 4 by yzshen@chromium.org, Oct 28 2017

The reason why https://chromium-review.googlesource.com/738013 resulted in a lot more failures:

The command line is updated to reflect the changes made through FeatureList. Without 738013, the original command line is ignored at the stage SetUpCommandLine(), so if feature foo is enabled, the command line eventually will be updated with --enable-features=foo. Although --enable-features=NetworkService is still in the command line, our CommandLine class only cares about the last occurrence if a switch appears multiple times.
With 738013, the original command line is taken into consideration at the stage of SetUpCommandLine(), so if feature foo is enabled, the command line is appended with --enable-features=foo,NetworkService.

Therefore, tests that enable features in SetUpCommandLine() (IIUC, "before ChromeBrowserMainParts::SetupFieldTrials" to be exact) will cause our NetworkService flag to be ignored (without 738013).
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c5bf3978c9509c808a1941c137b88ae9b48b51d

commit 9c5bf3978c9509c808a1941c137b88ae9b48b51d
Author: Min Qin <qinmin@chromium.org>
Date: Mon Oct 30 17:32:57 2017

Reenable browser_tests for linux_mojo and disable some failing tests



BUG= 779075 

Change-Id: I7dfb1425c06aa94c47094280bcce71938b17f568
Reviewed-on: https://chromium-review.googlesource.com/742653
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512525}
[modify] https://crrev.com/9c5bf3978c9509c808a1941c137b88ae9b48b51d/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9c5bf3978c9509c808a1941c137b88ae9b48b51d/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment