network_service_browser_tests timeout on mojo_linux |
|||
Issue descriptionSeeing lots of test failures/timeouts. Possibly related to https://chromium-review.googlesource.com/738013. Looks like those tests accidentally passes before that CL, and the CL exposes the actual failure. will disable the failing tests today
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f6d45116bf6ef36aafcbcd5e681059d8f9be36b commit 8f6d45116bf6ef36aafcbcd5e681059d8f9be36b Author: Min Qin <qinmin@chromium.org> Date: Fri Oct 27 21:23:59 2017 disable browser_tests on mojo_linux bot Lots of tests timed out, disable the test suite leaving the test filter file for now and will update it once we figure out all the timeout tests BUG= 779075 NOTRY=true NOTREECHECKS=true Change-Id: I29fe58f7d641c70b623656567475836cdda73121 Reviewed-on: https://chromium-review.googlesource.com/742140 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#512297} [modify] https://crrev.com/8f6d45116bf6ef36aafcbcd5e681059d8f9be36b/testing/buildbot/chromium.fyi.json
,
Oct 27 2017
,
Oct 28 2017
The reason why https://chromium-review.googlesource.com/738013 resulted in a lot more failures: The command line is updated to reflect the changes made through FeatureList. Without 738013, the original command line is ignored at the stage SetUpCommandLine(), so if feature foo is enabled, the command line eventually will be updated with --enable-features=foo. Although --enable-features=NetworkService is still in the command line, our CommandLine class only cares about the last occurrence if a switch appears multiple times. With 738013, the original command line is taken into consideration at the stage of SetUpCommandLine(), so if feature foo is enabled, the command line is appended with --enable-features=foo,NetworkService. Therefore, tests that enable features in SetUpCommandLine() (IIUC, "before ChromeBrowserMainParts::SetupFieldTrials" to be exact) will cause our NetworkService flag to be ignored (without 738013).
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c5bf3978c9509c808a1941c137b88ae9b48b51d commit 9c5bf3978c9509c808a1941c137b88ae9b48b51d Author: Min Qin <qinmin@chromium.org> Date: Mon Oct 30 17:32:57 2017 Reenable browser_tests for linux_mojo and disable some failing tests BUG= 779075 Change-Id: I7dfb1425c06aa94c47094280bcce71938b17f568 Reviewed-on: https://chromium-review.googlesource.com/742653 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#512525} [modify] https://crrev.com/9c5bf3978c9509c808a1941c137b88ae9b48b51d/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/9c5bf3978c9509c808a1941c137b88ae9b48b51d/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Jan 10
Archiving P3s older than 1 year with no owner or component. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 27 2017