Tagging with blocker label, please undo if not the case.

Hmm I think reverting the change is the best case since it has 2 regressions filed on it. What do you think m.jethani@ ?

Let me revert the change locally to see if this is in fact a regression due to that change.

It's possibly related to the fact that we forgot about @font-face rules. Do you think I should upload a patch instead, as I did for @keyframes?

Yup, if you can do the same with relative ease then why not?

OK, let me confirm that's what it is, then I'll start working on a patch. I'll post an update here.

I have confirmed that this issue is a regression from crrev.com/30168b9 because that change did not account for @font-face rules.

nainar@ can you land https://crrev.com/c/735263 so I can make my changes on top of it?

nainar@,
Could you please respond as per C#6 as we have scheduled beta release on 11/01 and this is marked as Beta blocker. Requesting to plan the fix or revert the CL.

Thanks in advance..!

Fix is in the CQ: https://chromium-review.googlesource.com/c/chromium/src/+/743642

Hi, I wanted to ask what time (SFO time) will the beta release take place? We are having some issues landing a change and even a revert will take some time.

Correction in C#7> This is marked as Beta blocker for M-64 which does't happen before Dec. 

nainar@: Please feel free to land the fix as per your convenience. 

Thank you!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3857f5dccf0f16288947c8c3c79b2a9a5bbd72b5

commit 3857f5dccf0f16288947c8c3c79b2a9a5bbd72b5
Author: Manish Jethani <m.jethani@eyeo.com>
Date: Wed Nov 01 16:46:46 2017

Support @font-face rules in user style sheets

@font-face rules in author style sheets are passed back to StyleEngine
via ScopedStyleResolver. With crrev.com/c/641294 we started treating
style sheets injected by extensions as user style sheets instead. Since
user style sheets apply to all scopes, they never go via
ScopedStyleResolver but are rather managed by StyleEngine directly.

crrev.com/c/641294 broke extensions using custom fonts because
StyleEngine fails to account for @font-face rules in user style sheets.

Fonts from both user and author style sheets must be maintained in the
same font cache. Even though style sheets can be added in any order,
@font-face rules in author style sheets must appear after those in user
style sheets. In order to achieve this result efficiently, we use a
"dirty" flag and refresh the font cache only once per cycle.

StyleEngine::ApplyRuleSetChanges may be called twice, once for user
style sheets (all scopes) and once for author style sheets (document
scope). If fonts have changed in user style sheets, we simply set the
dirty flag. If fonts have changed in author style sheets, we set the
dirty flag but also then refresh the font cache by first adding all the
@font-face rules from the active user style sheets and then re-adding
all the new author style sheets. This ensures that the font cache is
refreshed only once while the fonts are added in the correct order.

BUG= 632009 , 779048 

Change-Id: I58c1070af3ecae925e4afb91cbbb7cb00ee187fd
Reviewed-on: https://chromium-review.googlesource.com/743642
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513154}
[modify] https://crrev.com/3857f5dccf0f16288947c8c3c79b2a9a5bbd72b5/third_party/WebKit/Source/core/css/StyleEngine.cpp
[modify] https://crrev.com/3857f5dccf0f16288947c8c3c79b2a9a5bbd72b5/third_party/WebKit/Source/core/css/StyleEngine.h
[modify] https://crrev.com/3857f5dccf0f16288947c8c3c79b2a9a5bbd72b5/third_party/WebKit/Source/core/css/StyleEngineTest.cpp

Tested this issue on Windows 7, mac 10.12.6 & Ubuntu 14.04 using chrome latest Canary-64.0.3256.0 as per C#0.

Observed all the symbols loaded properly in "Amazon FBA calculator" extension overlay.As it as working as intended,adding TE Verified labels.

Please find the attached screencast for reference.

Thanks..!

Deleted: 779048.mp4 1.2 MB

	779048.mp4 1.2 MB View Download

nainar@,
This issue working as intended as per C#12,Could you please confirm is there any further work to be done here?.Please confirm.

Thanks..!