Non-Regression : Tab Focus is seen missing on 'Back' button immediately after focus is on 'File info' option in 'General Info' page of Files App |
||||||||||||||||
Issue descriptionChrome Version: 64.0.3249.0/10070.0.0 dev channel Paine,Kip and Peppy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Download any Image (2)Now Go to Files App -> Select saved page -> Right Click and select 'Get info' option or click on 'Space' Key (3)Now press 'Tab' button (Focus Traverses from 'Back' button) and wait until focus reaches to 'File info' option (4)Now again press 'Tab' button and observe Focus is not seen anywhere and now again press 'Tab' button -> Observe focus is on Back' button(Please refer Video) Expected: After Focus is on 'File info' option and on pressing 'Tab' Focus should be seen on 'Back' button Actual: Instead after 'File info' option Focus is seen missing on 'Back' button and on again pressing 'Tab' focus is seen This is Non-Regression Issue as 'Get info' option is newly introduced from M-55 @fukino: Please confirm the issue
,
Dec 8 2017
,
Jan 31 2018
,
Feb 23 2018
,
Feb 28 2018
,
Feb 28 2018
,
Mar 13 2018
,
Apr 5 2018
Luciano; can you check if this was fixed by your accessibility work? Thanks
,
Apr 11 2018
Hi, I can reproduce the issue, the focus is actually on the div that is displaying the image. It's because it has a tabindex=0 which was introduced as part of crbug.com/613465#c23 but it doesn't explicitly says "why". With screen reader/chromevox it doesn't read any information when focusing this div/image so I think it's safe to remove this tabindex.
,
Apr 12 2018
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd commit 9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Apr 16 06:41:56 2018 Remove tabindex from quick view inner content panel This fixes a "ghost" focus, where the tab puts the focus on the content panel/div and there isn't any visual clue about it. I tested screen reader/Chromevox and it wasn't reading anything when content panel/div was focused, also it doesn't seem necessary for any keyboard event handling, so it seems safe to remove and not have focus on this element. Bug: 779044 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0453792d1aa33918773f982944fc7358bece8587 Reviewed-on: https://chromium-review.googlesource.com/1004889 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#550943} [modify] https://crrev.com/9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
,
Apr 16 2018
It should be fixed with the patch above.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd commit 9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Apr 16 06:41:56 2018 Remove tabindex from quick view inner content panel This fixes a "ghost" focus, where the tab puts the focus on the content panel/div and there isn't any visual clue about it. I tested screen reader/Chromevox and it wasn't reading anything when content panel/div was focused, also it doesn't seem necessary for any keyboard event handling, so it seems safe to remove and not have focus on this element. Bug: 779044 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0453792d1aa33918773f982944fc7358bece8587 Reviewed-on: https://chromium-review.googlesource.com/1004889 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#550943} [modify] https://crrev.com/9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd/ui/file_manager/file_manager/foreground/elements/files_quick_view.html |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Nov 1 2017