Issue metadata
Sign in to add a comment
|
Regression : 'Google profile picture' is seen missing at User Id in chrome://settings |
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3249.0/10070.0.0 dev channel Paine,Kip and Peppy OS: Chrome What steps will reproduce the problem? (1)Sign into User which already has default 'Google profile picture' -> Go to chrome://settings page (2)Now observe No image is seen at User Id (Please refer Video and screenshot) Expected: Default 'Google profile picture' should be seen at User Id under 'people' section Actual: Instead Default 'Google profile picture' is seen missing at User Id This is Regression Issue as same is working fine in 64.0.3241.0/10041.0.0 dev-channel Peppy @stevenjb : Please confirm the Issue Note : issue 777373 is working fine on latest M-64 (Please refer '777373On64.0.3249.0' video)
,
Oct 30 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7248fbb91cb22965fb1427b4e3bc416de7bfabb7 commit 7248fbb91cb22965fb1427b4e3bc416de7bfabb7 Author: David Reveman <reveman@chromium.org> Date: Mon Oct 30 22:45:15 2017 Settings: Don't pass JPEG images to WebUI as image/png ProfileInfoHandler::GetAccountNameAndIcon expects chromeos::UserImageSource::GetUserImage to return a PNG image so webui::GetPngDataUrl can be used to create a profile icon data url from it that can be used by WebUI. This change makes UserImageSource::GetUserImage always return a PNG image so that the assumptions made in GetAccountNameAndIcon are correct. JPEG images with image/png mime type happen to work previously as Blink will ignore the mime type and look at the image signature to determine how to decode it. The code that was introduced to remove animations from PNG images is not that smart. Bug: 779042 Test: manual Change-Id: Ib33821f9a25d38626aa939b2540b2a77487de4dc Reviewed-on: https://chromium-review.googlesource.com/744907 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512653} [modify] https://crrev.com/7248fbb91cb22965fb1427b4e3bc416de7bfabb7/chrome/browser/ui/webui/chromeos/user_image_source.cc
,
Oct 30 2017
,
Oct 31 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 3 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8598cd98f0639e1ec281d3a33e1ef033b2165031 commit 8598cd98f0639e1ec281d3a33e1ef033b2165031 Author: David Reveman <reveman@chromium.org> Date: Fri Nov 03 05:11:20 2017 Settings: Don't pass JPEG images to WebUI as image/png ProfileInfoHandler::GetAccountNameAndIcon expects chromeos::UserImageSource::GetUserImage to return a PNG image so webui::GetPngDataUrl can be used to create a profile icon data url from it that can be used by WebUI. This change makes UserImageSource::GetUserImage always return a PNG image so that the assumptions made in GetAccountNameAndIcon are correct. JPEG images with image/png mime type happen to work previously as Blink will ignore the mime type and look at the image signature to determine how to decode it. The code that was introduced to remove animations from PNG images is not that smart. TBR=reveman@chromium.org (cherry picked from commit 7248fbb91cb22965fb1427b4e3bc416de7bfabb7) Bug: 779042 Test: manual Change-Id: Ib33821f9a25d38626aa939b2540b2a77487de4dc Reviewed-on: https://chromium-review.googlesource.com/744907 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#512653} Reviewed-on: https://chromium-review.googlesource.com/753022 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#362} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/8598cd98f0639e1ec281d3a33e1ef033b2165031/chrome/browser/ui/webui/chromeos/user_image_source.cc
,
Nov 7 2017
10032.29.0, 63.0.3239.37 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Oct 30 2017Owner: reve...@chromium.org