New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779032 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

StackView scrollview size needs to be resized on iPhone X.

Project Member Reported by jif@chromium.org, Oct 27 2017

Issue description

This is especially visible when starting Chrome and opening the StackView in landscape, and then switching to portrait (see attached video).
 
StackView scrollview size.mov
1.2 MB Download
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c28e695161d2e3db018dd78c1d0b743439e1a4d8

commit c28e695161d2e3db018dd78c1d0b743439e1a4d8
Author: Jean-François Geyelin <jif@chromium.org>
Date: Fri Oct 27 18:53:14 2017

Have the StackView's scrollview be positioned with autolayout.

Bug:  779032 ,  765408 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6731b515f1ae2e7f33dde48f9f4ab84334af530b
Reviewed-on: https://chromium-review.googlesource.com/741599
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512256}
[modify] https://crrev.com/c28e695161d2e3db018dd78c1d0b743439e1a4d8/ios/chrome/browser/ui/stack_view/stack_view_controller.mm

Comment 3 by jif@chromium.org, Oct 31 2017

Labels: Merge-Request-63
Status: Fixed (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 31 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-63 Merge-Approved-63
Owner: pkl@chromium.org
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 7 2017

Cc: cma...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by pkl@chromium.org, Nov 7 2017

I don't think we want to cherry-pick this to M63 branch because we have decided to not enable the SACT flag for M63 release. Looking at the code, the real change is bracketed inside the test for SACT flag.

Comment 9 Deleted

Labels: ReleaseBlock-Stable M-64
Labels: -M-63
Status: Verified (was: Fixed)
Verified in M64.0.3282.75 beta
iOS: 11.2.5
Device: iPhoneX

Stack View is displayed correctly after rotating the device.

Sign in to add a comment