New issue
Advanced search Search tips

Issue 779013 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 746956



Sign in to add a comment

[jumbo] Need a solution for all the Android JNI Init() methods

Project Member Reported by brat...@opera.com, Oct 27 2017

Issue description

The current JNI bindings declare a static Init(...) method in a number of files. When jumbo compiling all Init() methods end up in the same translation unit and it will not compile.

In content/browser for instance there is half a dozen or so Init() methods.


 

Comment 1 by brat...@opera.com, Nov 20 2017

Owner: brat...@opera.com
Status: Started (was: Untriaged)

Comment 2 by brat...@opera.com, Nov 20 2017

After talking with torne and others it was decided that it was better to fix it for all methods, not just for Init(). So a large patch is in https://chromium-review.googlesource.com/c/chromium/src/+/765973
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aacf9523d3616f046ee93e902ea5f95c874f609

commit 7aacf9523d3616f046ee93e902ea5f95c874f609
Author: Daniel Bratell <bratell@opera.com>
Date: Tue Nov 21 17:51:25 2017

Add the classname to JNI method names to make them unique

Our JNI code generator generated a lot of Init(...) methods which
collided in jumbo builds. This patch adds a class name prefix to
them, and all other JNI methods, so that they have locally unique names.

TBR=erikchen@chromium.org,fgorski@chromium.org,sergeyu@chromium.org,dtrainor@chromium.org,rouslan@chromium.org,vakh@chromium.org,rogerta@chromium.org,holte@chromium.org,bajones@chromium.org

Bug:  779013 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I86b6ac83c8e0a3507bd1d0efc48d625c12b4bb2b
Reviewed-on: https://chromium-review.googlesource.com/765973
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518300}
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/android_protocol_handler.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_contents_statics.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_debug.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_devtools_server.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_form_database.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_gl_functor.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_pdf_exporter.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_quota_manager_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_settings.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/aw_web_contents_delegate.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/popup_touch_handle_drawable.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/browser/token_binding_manager_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/android_webview/test/embedded_test_server/aw_embedded_test_server.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/animation_frame_time_histogram.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/application_status_listener.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/child_process_service_impl.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/command_line_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/cpu_features.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/early_trace_event_binding.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/field_trial_list.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/important_file_writer_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/java_exception_reporter.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/SampleForTests_jni.golden
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/jni_generator.py
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/sample_for_tests.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/testInnerClassNatives.golden
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/testInnerClassNativesMultiple.golden
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/testMultipleJNIAdditionalImport.golden
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/testNativeExportsOnlyOption.golden
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/testNatives.golden
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/jni_generator/testSingleJNIAdditionalImport.golden
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/library_loader/library_loader_hooks.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/memory_pressure_listener_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/path_service_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/record_histogram.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/record_user_action.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/statistics_recorder_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/sys_utils.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/time_utils.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/android/trace_event_binding.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/base/power_monitor/power_monitor_device_source_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/after_startup_task_utils_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/accessibility/font_size_prefs_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/appmenu/app_menu_drag_helper.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/bookmarks/bookmark_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/bottombar/overlay_panel_content.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/browsing_data/browsing_data_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/chrome_backup_agent.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/compositor_view.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/layer_title_cache.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/resources/resource_factory.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/scene_layer/scene_layer.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/scene_layer/static_tab_scene_layer.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/compositor/tab_content_manager.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/content/content_utils.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/contextualsearch/contextual_search_context.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/contextualsearch/contextual_search_manager.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/contextualsearch/contextual_search_tab_helper.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/contextualsearch/ctr_suppression.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/cookies/cookies_fetcher.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/customtabs/origin_verifier.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/devtools_server.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/document/document_web_contents_delegate.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/download/items/offline_content_aggregator_factory_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/download/service/download_background_task.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/favicon_helper.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/feature_engagement/tracker_factory_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/feature_utilities.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/feedback/connectivity_checker.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/feedback/screenshot_task.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/find_in_page/find_in_page_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/foreign_session_helper.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/history/browsing_history_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/history_report/history_report_jni_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/instantapps/instant_apps_infobar_delegate.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/instantapps/instant_apps_settings.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/large_icon_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/locale/locale_manager.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/locale/special_locale_handler.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/location_settings_impl.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/logo_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/metrics/uma_session_stats.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/metrics/uma_utils.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/metrics/variations_session.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/ntp/android_content_suggestions_notifier.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/ntp/recent_tabs_page_prefs.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/omnibox/answers_image_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/omnibox/autocomplete_controller_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/omnibox/omnibox_prerender.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/password_ui_view_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/payments/service_worker_payment_app_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/photo_picker_sandbox_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/physical_web/eddystone_encoder_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/physical_web/physical_web_data_source_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/policy/policy_auditor.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/preferences/pref_change_registrar_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/preferences/website_preference_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/profiles/profile_downloader_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/profiles/profile_manager_utils.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/provider/chrome_browser_provider.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/rappor/rappor_service_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/recently_closed_tabs_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/rlz/revenue_stats.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/rlz/rlz_ping_handler.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/search_permissions/search_geolocation_disclosure_tab_helper.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/service_tab_launcher.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/sessions/session_tab_helper_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/signin/account_management_screen_helper.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/signin/account_tracker_service_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/signin/signin_investigator_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/signin/signin_manager_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/tab_state.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/url_utilities.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/vr_shell/android_ui_gesture_target.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/vr_shell/vr_core_info.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/warmup_manager.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/web_contents_factory.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/webapk/chrome_webapk_host.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/webapk/webapk_update_manager.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/android/widget/thumbnail_generator.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/autofill/android/phone_number_util_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/dom_distiller/dom_distiller_service_factory_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/dom_distiller/tab_utils_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/engagement/site_engagement_service_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/invalidation/invalidation_service_factory_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/media/android/cdm/media_drm_credential_manager.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/media/android/remote/record_cast_action.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/offline_pages/android/background_scheduler_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/offline_pages/android/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/offline_pages/android/prefetch_background_task_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/password_manager/account_chooser_dialog_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/payments/android/journey_logger_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/payments/android/payment_manifest_web_data_service_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/payments/android/ssl_validity_checker_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/predictors/loading_predictor_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/prerender/external_prerender_handler_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/profiles/profile_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/profiling_host/test_android_shim.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/search_engines/template_url_service_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/signin/oauth2_token_service_delegate_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/ssl/captive_portal_helper_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/ssl/security_state_model_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/supervised_user/child_accounts/child_account_service_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/supervised_user/supervised_user_content_provider_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/sync/sessions/sync_sessions_metrics_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f95c874f609/chrome/browser/ui/android/infobars/infobar_container_android.cc
[modify] https://crrev.com/7aacf9523d3616f046ee93e902ea5f9

Comment 4 by brat...@opera.com, Nov 21 2017

Status: Fixed (was: Started)
Landed. Now the boundary functions are called JNI_ClassName_FunctionName.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26ebf15fcb6f642fb7c0d19ceb3fd6df2918c7dd

commit 26ebf15fcb6f642fb7c0d19ceb3fd6df2918c7dd
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Nov 22 20:27:51 2017

Remove jumbo_excludes triggered by too many Init()

The Android JNI generator generated code that cause there to be a
lot of Init() methods in Android code. The JNI generator has now
been changed to add a class name prefix to the function names
so these excludes are no longer needed.

This will speed up Android jumbo builds by a couple of seconds or so
(not measured).

Bug:  779013 ,746953
Change-Id: I24e550d6e493f87022e9887f7a957dc557233b20
Reviewed-on: https://chromium-review.googlesource.com/783212
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#518728}
[modify] https://crrev.com/26ebf15fcb6f642fb7c0d19ceb3fd6df2918c7dd/content/browser/BUILD.gn

Sign in to add a comment