New issue
Advanced search Search tips

Issue 779012 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cancelled downloads should never send the Client any messages other than a single failed

Project Member Reported by delph...@chromium.org, Oct 27 2017

Issue description

This bug is based on the issue I reported via email:

It appears that if I cancel a job, Client::OnDownloadSucceeded can still be called. 

This happens because that call is posted, rather than invoked first so presumably the download completed before I cancelled it (but my code had no way of knowing that).

Additionally I think it's possible for the client to receive two OnDownloadFailed messages if they cancel. One with CANCELLED and one with something else.

It seems to me that methods like SendOnDownloadSucceeded (which are posted), should check if the download has been aborted before actually sending the message.

 
Cc: xingliu@chromium.org
I think this ends up being a bit more complicated to implement than I thought.  Looking into it though.
Status: Assigned (was: Untriaged)

Comment 3 by na...@chromium.org, May 9 2018

Any updates here guys?

Sign in to add a comment