Issue metadata
Sign in to add a comment
|
Non-Regression:Focus missing is seen on toggle button of Highlighting section while tabbing |
||||||||||||||||||||||||||
Issue descriptionChrome Version:64.0.3249.0/10070.0.0 dev channel Paine,Kip,Peppy OS:Chrome OS What steps will reproduce the problem? (1)Sign into user > launch chrome and navigate to chrome://settings/manageAccessibility (2)In Text-to-Speech section ->click to Open select-to-speak settings page (3)Press tabbing and Observe no focus is seen on toggle button of Highlighting (Please find the attached screencast for your reference.) Actual: No focus is seen on toggle button of Highlighting section while tabbing Expected: Focus should be seen on toggle button of Highlighting section while tabbing This is a Non-Regression issue since the feature is implemented in M-64 Note:Issue is not seen In Linux,Windows OS @stevenjb: Please confirm the issue.
,
Nov 29 2017
,
Nov 30 2017
Looks like tab does select the button, but the style isn't changing when it is focused. We are using a checkbox with a custom icon here rather than a cr-toggle (which has a nice ripple built-in). Repro: Tab three times to get to the button. Hit "space" , and the toggle is switched on or off. Two possible solutions: 1. Can we use cr-toggle here and in ChromeVox too? 2. Get some images with the ripple and just set those for checked/unchecked focus
,
Nov 30 2017
1. Can we use cr-toggle here and in ChromeVox too? Not with the current architecture, since S2S and ChromeVox are extensions and don't have access to the the rest of the WebUI architecture. It'd be possible, and interesting, to make use of classes like cr-toggle, but it'd be a lot of work to set up at first. 2. Get some images with the ripple and just set those for checked/unchecked focus This seems like the easiest. Perhaps the best solution would be to make S2S options just part of the main Chrome options page. It really ought to act more like a built-in feature and not like a separate extension. It could be in a sub-page, or the options could just slide out when you enable S2S. We should go through UI review for that. That's a bit more work, but certainly much less work than making it possible for extensions to use cr-toggle.
,
Feb 27 2018
We'd probably need UX approval to move the S2S options into the Chrome options page. @lpalmaro, do you think UX would consider adding all these STS options, visually, into the chrome::settings/manageAccessibility page? In addition, the same thing is seen in Chromevox, which may be too many options to port into the Chrome options page.
,
Mar 19 2018
,
Mar 19 2018
,
Sep 7
,
Sep 27
Issue 883239 has been merged into this issue.
,
Oct 1
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Oct 30 2017Components: -UI>Settings UI>Accessibility
Owner: ----
Status: Untriaged (was: Assigned)