New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778991 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-1.3% regression in system_health.memory_desktop at 511402:511477

Project Member Reported by petermarshall@chromium.org, Oct 27 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 27 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=778991

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=dce6de0dbf0c130bfd2e2a68a27c92db601263cf43f7aab575d1bf6d7d3693c1


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac12
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
win-high-dpi
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 27 2017

Cc: kozyatinskiy@chromium.org
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author kozyatinskiy@chromium.org ===

Hi kozyatinskiy@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Alexey Kozyatinskiy
  Commit : b2e85a2f81015193134de039cc5f4dd7c59ecd07
  Date   : Wed Oct 25 06:14:06 2017
  Subject: [inspector] removed unused injected-script methods

Bisect Details
  Configuration: win_x64_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/load_chrome/load_chrome_blank
  Change       : 0.03% | 2286648.0 -> 2286072.0

Revision                           Result              N
chromium@511403                    2286648 +- 0.0      6      good
chromium@511412                    2286808 +- 0.0      6      good
chromium@511414                    2286808 +- 0.0      6      good
chromium@511415                    2286808 +- 0.0      6      good
chromium@511415,v8@343bf6f3ff      2286808 +- 0.0      6      good
chromium@511415,v8@b2e85a2f81      2286072 +- 0.0      6      bad       <--
chromium@511416                    2286072 +- 0.0      6      bad
chromium@511420                    2286072 +- 0.0      6      bad
chromium@511436                    2286072 +- 0.0      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.chrome.blank system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964598344903481840


For feedback, file a bug with component Speed>Bisection

Comment 4 by kozy@chromium.org, Oct 27 2017

Status: WontFix (was: Assigned)
My CL removed some unused code and can only reduce memory usage. Looks like noise.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Oct 27 2017

Cc: tguilbert@chromium.org
 Issue 779173  has been merged into this issue.

Sign in to add a comment