New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778989 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 709301



Sign in to add a comment

Move the GeolocationService interface out of geolocation.mojom to be part of the Blink interfaces instead.

Project Member Reported by ke...@intel.com, Oct 27 2017

Issue description

Design doc: https://docs.google.com/document/d/1V-HsypJveArl_LQox4ksxC7kTl7vnhlCudhbU6o0tRQ/edit#

This is one step of "Decouple permissions from the geolocation core".
 

Comment 1 by ke...@intel.com, Oct 27 2017

Description: Show this description

Comment 2 by ke...@intel.com, Oct 27 2017

Blocking: 709301
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2664364239847d09444d7b05cddba715c3ccefac

commit 2664364239847d09444d7b05cddba715c3ccefac
Author: Ke He <ke.he@intel.com>
Date: Thu Nov 02 17:57:50 2017

Move the GeolocationService interface into blink.

Move the GeolocationService interface out of geolocation.mojom to be part of
the Blink interfaces instead.
This is one step of the whole Geolocation Servicification.
Design doc: 
https://docs.google.com/document/d/1V-HsypJveArl_LQox4ksxC7kTl7vnhlCudhbU6o0tRQ/edit

BUG= 778989 

Change-Id: I94151153a783bb15779e94468bfdafde21649f3e
Reviewed-on: https://chromium-review.googlesource.com/741521
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#513548}
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/content/browser/DEPS
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/content/browser/geolocation/geolocation_service_impl.cc
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/content/browser/geolocation/geolocation_service_impl.h
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/content/browser/geolocation/geolocation_service_impl_unittest.cc
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/device/geolocation/public/interfaces/geolocation.mojom
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/cached-position-called-once.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/callback-exception-expected.txt
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/callback-exception.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/callback-to-deleted-context.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/clear-watch-invalid-id-crash.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/coordinates-interface-attributes.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed-for-multiple-requests.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied-for-multiple-requests.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-already.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-permission-denied.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/error-clear-watch.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/error-service-connection-error.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/error.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/maximum-age.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/multiple-requests.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/notimer-after-unload.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-clear-watch.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-error.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-success.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-stops-watches.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/permission-denied.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/position-string.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/reentrant-error.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/reentrant-permission-denied.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/reentrant-success.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/resources/callback-to-remote-context-inner.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/resources/geolocation-mock.js
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/resources/remove-remote-context-in-error-callback-crash-inner.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/resources/window-close-popup.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/success-clear-watch.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/success.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/timeout-clear-watch.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/timeout-negative.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/timeout-over-max-of-unsigned.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/timeout-zero.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/timeout.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/timestamp.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/watch.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/watchPosition-page-visibility.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/geolocation-api/watchPosition-unique.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/resources/geolocation.html
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/Source/modules/geolocation/Geolocation.h
[modify] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/public/platform/modules/geolocation/OWNERS
[add] https://crrev.com/2664364239847d09444d7b05cddba715c3ccefac/third_party/WebKit/public/platform/modules/geolocation/geolocation_service.mojom

Comment 4 by ke...@intel.com, Nov 9 2017

Status: Fixed (was: Started)

Sign in to add a comment