Issue metadata
Sign in to add a comment
|
Regression: Text in 'Google chrome OS terms'page moves down while clicking Back & Next buttons |
||||||||||||||||||||||
Issue descriptionChrome Version:64.0.3249.0/10070.0.0 dev channel Paine,Kip,Peppy OS:chrome OS What steps will reproduce the problem? (1)Recover Build >>Connect to a network (2)Goto 'Google chrome OS terms'page and press 'Back' button in that page (3)Now, in Connect to network page click 'next' button (4)Repeat Steps (2) & (3) for sometime and Observe 'Optional statement' moves down (please refer video) Actual:'Optional statement' below system security setting in 'Google chrome OS terms'page moves down Expected: No such unnecessary movements should be seen This is a Regression issue as same is working fine in 64.0.3244.0/10051.0.0 dev channel Paine Note:Issue is not seen in Linux,Windows OS @alemate: Please confirm the issue.
,
Nov 1 2017
Issue 778576 has been merged into this issue.
,
Nov 3 2017
Put on M63 since the offending CL is merged to M63.
,
Nov 3 2017
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8535de60c5047263328ed2c9d6e82aef69661a69 commit 8535de60c5047263328ed2c9d6e82aef69661a69 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Nov 06 20:52:46 2017 cros: Fix eula height regression Use a fixed height on webview to work around the wrong height calculated for its inner iframe. Previously, the work around is to set a fixed height on #eulaDialog but that has a problem that webview height grows when it gains/loses focus. Bug: 778978 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6be9054566f53251afe6bf3bca2972fa1d45ab7b Reviewed-on: https://chromium-review.googlesource.com/754296 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#514238} [modify] https://crrev.com/8535de60c5047263328ed2c9d6e82aef69661a69/chrome/browser/resources/chromeos/login/oobe_eula.css [modify] https://crrev.com/8535de60c5047263328ed2c9d6e82aef69661a69/chrome/browser/resources/chromeos/login/oobe_eula.html
,
Nov 6 2017
,
Nov 7 2017
Let's have this verified on tot first before approving merge to M63 branch.
,
Nov 7 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 8 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b556b17b91e0ad288841705127a1fb3f8dd99ba commit 9b556b17b91e0ad288841705127a1fb3f8dd99ba Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Nov 08 23:45:56 2017 Merge M63 "cros: Fix eula height regression" > Use a fixed height on webview to work around the wrong height > calculated for its inner iframe. Previously, the work around > is to set a fixed height on #eulaDialog but that has a problem > that webview height grows when it gains/loses focus. > > Bug: 778978 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I6be9054566f53251afe6bf3bca2972fa1d45ab7b > Reviewed-on: https://chromium-review.googlesource.com/754296 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#514238} > (cherry picked from commit 8535de60c5047263328ed2c9d6e82aef69661a69) Change-Id: I7962c34e3ba310a55d6e693de5da03adfa8e3e50 Reviewed-on: https://chromium-review.googlesource.com/758966 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#424} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/9b556b17b91e0ad288841705127a1fb3f8dd99ba/chrome/browser/resources/chromeos/login/oobe_eula.css [modify] https://crrev.com/9b556b17b91e0ad288841705127a1fb3f8dd99ba/chrome/browser/resources/chromeos/login/oobe_eula.html
,
Nov 8 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alemate@chromium.org
, Nov 1 2017Owner: xiy...@chromium.org