Settings hides immediately after clicking the setting button on popup |
|||
Issue descriptionChrome Version: Canary (64.0.3249.0) OS: Chrome OS What steps will reproduce the problem? (1) Show a HTML 5 notification (2) See a popup notification on desktop (not in the message center) (3) Click the settings button on popup What is the expected result? The setting bubble shows and keeps showing What happens instead? The setting bubble shows for a moment but hides immediately
,
Oct 27 2017
,
Oct 27 2017
It was because of my recent changes. Sorry for that and I would fix it soon.
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76cc1e35b6c08b6597b3cb18ca49460a9f5e42e4 commit 76cc1e35b6c08b6597b3cb18ca49460a9f5e42e4 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Oct 30 21:57:15 2017 Don't close tray bubble when notification popup is deactivated. When the settings button in a notification popup is clicked, the notification is activated and hidden almost at the same time. In such case, the notification is deactivated without OnWindowActivated for the activation being called. We have to manually ignore such case in TrayBubbleWrapper::OnWindowActivated. TEST=manual BUG= 778973 Change-Id: I90802a99a64bd8a9d8de56e48735e0fd7abe6ed6 Reviewed-on: https://chromium-review.googlesource.com/740928 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#512639} [modify] https://crrev.com/76cc1e35b6c08b6597b3cb18ca49460a9f5e42e4/ash/system/tray/tray_bubble_wrapper.cc
,
Oct 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by yoshiki@chromium.org
, Oct 27 2017