New issue
Advanced search Search tips

Issue 778960 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: false in query_manager.cc

Project Member Reported by ClusterFuzz, Oct 27 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6310647246880768

Fuzzer: libFuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in query_manager.cc
  gpu::gles2::CommandsCompletedQuery::QueryCounter
  gpu::gles2::QueryManager::QueryCounter
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=419732:419790

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6310647246880768

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Cc: kkaluri@chromium.org
Components: Internals>GPU
Labels: M-63 Test-Predator-Wrong
Owner: piman@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.

Using the CL for the file, “query_manager.cc” assigning to concern owner for his recent work on this file.

Suspect CL : https://chromium.googlesource.com/chromium/src/+/106c0422016d35b03f80fbb40fe11146f75d3b20

piman@ -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.


Thank You.

Comment 2 by piman@chromium.org, Oct 27 2017

Components: -Internals>GPU Internals>GPU>Internals
I think the NOTREACHED is wrong, will fix.

Comment 3 by piman@chromium.org, Oct 28 2017

Cc: zmo@chromium.org
Actually, NOTREACHED is right, we're missing some validation. Fix here: https://chromium-review.googlesource.com/c/chromium/src/+/742359
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a8a907a26d331973f68e3bf63ecd24ad8d652fd

commit 2a8a907a26d331973f68e3bf63ecd24ad8d652fd
Author: Antoine Labour <piman@chromium.org>
Date: Mon Oct 30 18:55:50 2017

Fix QueryCounter when target doesn't match query target

Bug:  778960 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic9db9a17fa7b7dea133673c0851bfa72b3f5ffff
Reviewed-on: https://chromium-review.googlesource.com/742359
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512560}
[modify] https://crrev.com/2a8a907a26d331973f68e3bf63ecd24ad8d652fd/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/2a8a907a26d331973f68e3bf63ecd24ad8d652fd/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

Project Member

Comment 5 by ClusterFuzz, Oct 31 2017

ClusterFuzz has detected this issue as fixed in range 512553:512596.

Detailed report: https://clusterfuzz.com/testcase?key=6310647246880768

Fuzzer: libFuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in query_manager.cc
  gpu::gles2::CommandsCompletedQuery::QueryCounter
  gpu::gles2::QueryManager::QueryCounter
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=419732:419790
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=512553:512596

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6310647246880768

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Oct 31 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6310647246880768 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment