New issue
Advanced search Search tips

Issue 778955 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 776257



Sign in to add a comment

Run clang-tidy modernize-use-bool-literals

Project Member Reported by w...@chromium.org, Oct 27 2017

Issue description

Replaces integer literals which are cast to bool with bool literals.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/393f8994d2aa1a9c66fd69eaf1c9418ae2bb92ee

commit 393f8994d2aa1a9c66fd69eaf1c9418ae2bb92ee
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Thu Nov 30 15:46:51 2017

Run clang-tidy modernize-use-bool-literals on //third_party/pdfium

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

Bug: chromium:778955
Change-Id: Ib037ed749539e4380fb336fc6fa85648fc506118
Reviewed-on: https://pdfium-review.googlesource.com/19990
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/393f8994d2aa1a9c66fd69eaf1c9418ae2bb92ee/third_party/base/numerics/safe_conversions_impl.h

Comment 2 by w...@chromium.org, Dec 1 2017

Description: Show this description
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 3

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment