See blocked bug for details.
kotenkov@ I figured we should make a bug per check to avoid spamming the tracking bug with hundreds of CL posts so we can still reasonably discuss there.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10 commit 2c0d2bb3fe0614135fe6648b63ed4542cfdbec10 Author: Ivan Kotenkov <kotenkov@yandex-team.ru> Date: Wed Nov 01 15:41:28 2017 Convert 0 to nullptr in content using clang-tidy. Bug: 778942 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Iee6be84c23149c745b3afd6e6158764f92ccd17f Reviewed-on: https://chromium-review.googlesource.com/732305 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ivan Kotenkov <kotenkov@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#513138} [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/app/content_main_runner.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/accessibility/accessibility_ui.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/accessibility/browser_accessibility.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/accessibility/browser_accessibility_auralinux.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/accessibility/hit_testing_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_backend_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_disk_cache.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_disk_cache_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_group.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_group_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_host_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_interceptor.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_quota_client.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_request_handler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_request_handler_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_response.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_response_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_service_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_storage_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_storage_impl_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_storage_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_update_job.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_update_job_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_url_request_job.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/appcache_url_request_job_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/chrome_appcache_service.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/chrome_appcache_service_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/appcache/mock_appcache_storage_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/blob_storage/blob_dispatcher_host_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/blob_storage/blob_url_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/blob_storage/chrome_blob_storage_context.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/browser_context.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/browser_main_loop.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/browser_main_runner.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/browser_shutdown_profile_dumper.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/browser_url_handler_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/browsing_data/storage_partition_http_cache_data_remover.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/byte_stream.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/cache_storage/cache_storage.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/cache_storage/cache_storage_cache.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/child_process_security_policy_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/child_process_security_policy_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/compositor/owned_mailbox.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/devtools/devtools_http_handler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/devtools/devtools_manager_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/devtools/protocol/tethering_handler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/devtools/shared_worker_devtools_manager_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/dom_storage/dom_storage_area.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/dom_storage/dom_storage_area_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/dom_storage/dom_storage_context_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/dom_storage/dom_storage_context_impl_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/dom_storage/dom_storage_database.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/dom_storage/dom_storage_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/dom_storage/dom_storage_message_filter.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/dom_storage/dom_storage_namespace.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/dom_storage/session_storage_database.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/download/download_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/download/download_file_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/download/download_item_impl_delegate.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/download/download_item_impl_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/download/download_manager_impl_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/download/download_request_core.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/download/drag_download_file.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/download/drag_download_util.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/download/save_file_manager.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/fileapi/browser_file_system_helper.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/fileapi/fileapi_message_filter.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/fileapi/fileapi_message_filter_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/interstitial_page_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/navigation_controller_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/navigation_controller_impl_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/navigation_controller_impl_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/navigation_entry_impl_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/navigation_entry_screenshot_manager.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/navigator.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/navigator_impl_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/render_frame_host_delegate.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/render_frame_host_factory.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/render_frame_host_manager_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/render_frame_host_manager_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/frame_host/render_widget_host_view_guest_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/gpu/browser_gpu_channel_host_factory.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/gpu/gpu_feature_checker_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/gpu/gpu_ipc_browsertests.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/histogram_controller.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/histogram_synchronizer.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_active_blob_registry.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_backing_store.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_connection.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_context_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_database.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_database_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_factory_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_fake_backing_store.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/indexed_db_quota_client_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/indexed_db/leveldb/leveldb_database.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/detachable_resource_handler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/mime_sniffing_resource_handler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/redirect_to_file_resource_handler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/resource_buffer.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/resource_dispatcher_host_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/resource_loader.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/resource_loader_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/resource_request_info_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/resource_scheduler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/resource_scheduler_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/temporary_file_stream_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/throttling_resource_handler_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/loader/upload_data_stream_builder_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/media/capture/audio_mirroring_manager.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/media/capture/aura_window_capture_machine.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/media/capture/desktop_capture_device_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/media/capture/web_contents_audio_input_stream.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/media/capture/web_contents_video_capture_device_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/media/media_internals.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/net/view_http_cache_job_factory.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/notification_service_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/plugin_data_remover_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/plugin_service_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/ppapi_plugin_process_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/quota_dispatcher_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/delegated_frame_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/dip_util.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/font_utils_linux.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/input/composited_scrolling_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/input/input_router_impl_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/input/mock_input_disposition_handler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/input/mock_input_router_client.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/input/touch_action_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/media/media_stream_manager.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/media/media_stream_ui_proxy.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_file_ref_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_network_proxy_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_print_settings_manager.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_truetype_font_host.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_truetype_font_list_pango.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_process_host_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_view_host_delegate.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_view_host_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_widget_helper.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_widget_host_delegate.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_widget_host_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/renderer_host/render_widget_host_view_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/resolve_proxy_msg_helper.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/resolve_proxy_msg_helper_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/security_exploit_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_controllee_request_handler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_database.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_handle_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_internals_ui.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_register_job.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_registration.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_registration_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_request_handler.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_storage_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/service_worker/service_worker_version_unittest.cc [modify] https://crrev.com/2c0d2bb3fe0614135fe6648b63ed4542cfdbec10/content/browser/shareable_file_ref
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce523e632310e04ebe399f63c8a0c3ab32edac7c commit ce523e632310e04ebe399f63c8a0c3ab32edac7c Author: Stuart Langley <slangley@chromium.org> Date: Fri Nov 24 09:15:42 2017 Run clang-tidy modernize-use-nullptr on WebKit/Source/core & fix errors. I followed the instructions to run clang tidy at https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md. I then ran the modernize-use-nullptr check on WebKit/Source/core using the following command: $(LLVM_HOME)/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary $(LLVM_BUILD)/bin/clang-tidy \ -clang-apply-replacements-binary $(LLVM_BUILD)/bin/clang-apply-replacements \ -checks=-*,modernize-use-nullptr \ -header-filter=third_party/WebKit/Source/core/* \ -fix \ third_party/WebKit/Source/core Then ran "git cl format" on the result. Bug: 778942 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia74d45f20d0a78ca116ab9c72560372a6b181023 Reviewed-on: https://chromium-review.googlesource.com/788475 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#519073} [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/clipboard/DataObject.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/CSSCustomFontData.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/CSSImageValue.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/CSSPropertyValueSet.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/CSSRule.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/CSSRuleList.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/CSSSelector.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/CSSSelectorList.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/PseudoStyleRequest.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/StyleSheet.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/css/StyleSheetContents.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/ElementTraversal.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/EmptyNodeList.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/IgnoreDestructiveWriteCountIncrementer.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/LiveNodeList.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/LiveNodeListBase.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/MutationObserverInterestGroup.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/NodeComputedStyle.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/NodeList.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/NodeListsNodeData.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/NodeTraversal.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/StaticNodeList.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/dom/V0InsertionPoint.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/editing/EditingStyle.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/editing/Position.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/editing/RenderedPosition.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/frame/FrameTestHelpers.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/frame/LocalFrameClient.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/HTMLCollection.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/HTMLElement.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/HTMLLinkElement.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/HTMLMetaElement.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/custom/V0CustomElementProcessingStack.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/forms/DateTimeEditElement.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/forms/FileChooser.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/forms/HTMLFormControlsCollection.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/forms/HTMLFormElement.cpp [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/media/HTMLMediaSource.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/parser/HTMLEntitySearch.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/parser/HTMLToken.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/html/track/TrackListBase.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/LayoutBox.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/LayoutCounter.cpp [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/LayoutGeometryMap.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/LayoutImage.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/LayoutObjectChildList.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/api/LayoutItem.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/line/EllipsisBox.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/line/InlineIterator.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/layout/svg/SVGResources.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/page/FrameTree.cpp [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/paint/PaintLayer.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/paint/PaintLayerClipper.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/paint/PaintLayerStackingNode.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/paint/TextPainter.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/plugins/PluginView.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/style/FillLayer.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/style/FilterOperations.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/style/StyleImage.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/style/StylePendingImage.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/svg/SVGGraphicsElement.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/testing/DummyPageHolder.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/testing/PageTestBase.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/xml/parser/XMLDocumentParserScope.h [modify] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/Source/core/xml/parser/XMLParserInput.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8034f6304fb299339d902e8adef24817de0be9f4 commit 8034f6304fb299339d902e8adef24817de0be9f4 Author: Stuart Langley <slangley@chromium.org> Date: Sun Nov 26 23:06:55 2017 Run clang-tidy modernize-use-nullptr on WebKit/Source/platform & fix errors. I followed the instructions to run clang tidy at https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md. I then ran the modernize-use-nullptr check on WebKit/Source/platform using the following command: $LLVM_HOME/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary $LLVM_BUILD/bin/clang-tidy \ -clang-apply-replacements-binary $LLVM_BUILD/bin/clang-apply-replacements \ -checks=-*,modernize-use-nullptr \ -header-filter=third_party/WebKit/Source/platform/* \ -fix \ third_party/WebKit/Source/platform Then ran "git cl format" on the result. Bug: 778942 Change-Id: I85acd9d6150bbe0dd9419f53aab07915464544ab Reviewed-on: https://chromium-review.googlesource.com/789714 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#519197} [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/ContextMenuItem.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/PODArena.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/PODFreeListArena.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/PODIntervalTree.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/PODRedBlackTree.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/bindings/V8GlobalValueMap.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/fonts/Font.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/fonts/FontPlatformData.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/geometry/TransformState.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/graphics/BitmapImage.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/graphics/GraphicsContext.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/graphics/Image.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/heap/CallbackStack.cpp [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/heap/HeapAllocator.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/heap/HeapPage.cpp [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/scroll/Scrollbar.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/text/BidiCharacterRun.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/text/BidiContext.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/text/BidiResolver.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/text/BidiRunList.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/text/TextBreakIterator.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/text/TextRun.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/text/TextRunIterator.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/transforms/TransformOperations.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/transforms/TransformationMatrix.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/DoublyLinkedList.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/HashTable.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/LinkedHashSet.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/ListHashSet.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/ScopedLogger.cpp [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/TerminatedArray.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/TreeNode.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/dtoa/double-conversion.cc [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/dtoa/utils.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/AtomicString.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/Base64.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/CString.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/StringBuffer.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/StringImpl.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/StringUTF8Adaptor.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/TextEncoding.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/UTF8.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/text/WTFString.h [modify] https://crrev.com/8034f6304fb299339d902e8adef24817de0be9f4/third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBuffer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e7d41e73e699e154a3c59b41d2980d04e53cacc commit 1e7d41e73e699e154a3c59b41d2980d04e53cacc Author: Stuart Langley <slangley@chromium.org> Date: Sun Nov 26 23:08:13 2017 Run clang-tidy modernize-use-nullptr on WebKit/Source/modules & fix errors. I followed the instructions to run clang tidy at https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md. I then ran the modernize-use-nullptr check on WebKit/Source/modules using the following command: $LLVM_HOME/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary $LLVM_BUILD/bin/clang-tidy \ -clang-apply-replacements-binary $LLVM_BUILD/bin/clang-apply-replacements \ -checks=-*,modernize-use-nullptr \ -header-filter=third_party/WebKit/Source/modules/* \ -fix \ third_party/WebKit/Source/modules Then ran "git cl format" on the result. Bug: 778942 Change-Id: I14a70e05023ad4bcbf84e119f021403f09bca6fc Reviewed-on: https://chromium-review.googlesource.com/789716 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#519198} [modify] https://crrev.com/1e7d41e73e699e154a3c59b41d2980d04e53cacc/third_party/WebKit/Source/modules/accessibility/AXObject.h [modify] https://crrev.com/1e7d41e73e699e154a3c59b41d2980d04e53cacc/third_party/WebKit/Source/modules/canvas/canvas2d/Path2D.h [modify] https://crrev.com/1e7d41e73e699e154a3c59b41d2980d04e53cacc/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h [modify] https://crrev.com/1e7d41e73e699e154a3c59b41d2980d04e53cacc/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h [modify] https://crrev.com/1e7d41e73e699e154a3c59b41d2980d04e53cacc/third_party/WebKit/Source/modules/mediasource/SourceBufferList.h [modify] https://crrev.com/1e7d41e73e699e154a3c59b41d2980d04e53cacc/third_party/WebKit/Source/modules/vr/latest/VRWebGLDrawingBuffer.cpp [modify] https://crrev.com/1e7d41e73e699e154a3c59b41d2980d04e53cacc/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43753f9d9a90ecad9bd491a886015519913b2f5a commit 43753f9d9a90ecad9bd491a886015519913b2f5a Author: Stuart Langley <slangley@chromium.org> Date: Mon Nov 27 23:57:46 2017 Run modernize-null-ptr over WebKit/Source/. This should be the final CL for moving to nullptr in WebKit/Source/* I followed the instructions to run clang tidy at https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md. I then ran the modernize-use-nullptr check on WebKit/Source/modules using the following command: $LLVM_HOME/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary $LLVM_BUILD/bin/clang-tidy \ -clang-apply-replacements-binary $LLVM_BUILD/bin/clang-apply-replacements \ -checks=-*,modernize-use-nullptr \ -header-filter=third_party/WebKit/Source/* \ -fix \ third_party/WebKit/Source Then ran "git cl format" on the result. Bug: 778942 Change-Id: I31f0cba131523034a7811bf46f8ef68110d11a3f Reviewed-on: https://chromium-review.googlesource.com/791410 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#519462} [modify] https://crrev.com/43753f9d9a90ecad9bd491a886015519913b2f5a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h [modify] https://crrev.com/43753f9d9a90ecad9bd491a886015519913b2f5a/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h [modify] https://crrev.com/43753f9d9a90ecad9bd491a886015519913b2f5a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h [modify] https://crrev.com/43753f9d9a90ecad9bd491a886015519913b2f5a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h [modify] https://crrev.com/43753f9d9a90ecad9bd491a886015519913b2f5a/third_party/WebKit/Source/core/css/CSSImageValue.h [modify] https://crrev.com/43753f9d9a90ecad9bd491a886015519913b2f5a/third_party/WebKit/Source/platform/PODRedBlackTree.h [modify] https://crrev.com/43753f9d9a90ecad9bd491a886015519913b2f5a/third_party/WebKit/Source/platform/Supplementable.h [modify] https://crrev.com/43753f9d9a90ecad9bd491a886015519913b2f5a/third_party/WebKit/Source/platform/text/BidiResolver.h
kotenkov@: Do you know why Stuart is seeing so many instances of 0's for null pointers when you recently did all of third_party/WebKit a while back?
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/a8548dc2de6c2ba098190d76444bfe4cd8174466 commit a8548dc2de6c2ba098190d76444bfe4cd8174466 Author: Dan Sinclair <dsinclair@chromium.org> Date: Thu Nov 30 16:37:20 2017 Run clang-tidy modernize-use-nullptr on //third_party/pdfium See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md Bug: chromium:778942 Change-Id: I5d94299404647d231c0dc8ef8b75a6c0539f378c Reviewed-on: https://pdfium-review.googlesource.com/19972 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> [modify] https://crrev.com/a8548dc2de6c2ba098190d76444bfe4cd8174466/third_party/base/allocator/partition_allocator/partition_alloc.h
Comment 1 by w...@chromium.org
, Oct 27 2017