New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778938 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Floating-point-exception in safe_browsing::dmg::HFSForkReadStream::Seek

Project Member Reported by ClusterFuzz, Oct 27 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5927606896820224

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Floating-point-exception
Crash Address: 
Crash State:
  safe_browsing::dmg::HFSForkReadStream::Seek
  safe_browsing::dmg::HFSBTreeIterator::Init
  start
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5927606896820224

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Cc: msrchandra@chromium.org pnangunoori@chromium.org
Labels: M-64 Test-Predator-Wrong
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using the code search for the file, “hfs.cc” assigning to concern owner from GIT revision log.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/3749e7b625216973a65a6cbef1cea950097021a2

@rsesek -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.
Thank You.

Comment 2 by rsesek@chromium.org, Oct 27 2017

Components: Services>Safebrowsing
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b679216df2b4c3f25c703f2a3a1330365d77168

commit 9b679216df2b4c3f25c703f2a3a1330365d77168
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Oct 27 16:44:46 2017

Fix FPE/div-by-0 in safe_browsing::dmg::HFSForkReadStream::Seek().

Bug:  778938 
Test: Covered by safe_browsing_hfs_fuzzer
Change-Id: I93b1f04d59d88634beb4f1e1d4a0d0637206b349
Reviewed-on: https://chromium-review.googlesource.com/741842
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512205}
[modify] https://crrev.com/9b679216df2b4c3f25c703f2a3a1330365d77168/chrome/utility/safe_browsing/mac/hfs.cc

Comment 4 by vakh@chromium.org, Oct 27 2017

Labels: SafeBrowsing-Triaged
Project Member

Comment 5 by ClusterFuzz, Oct 28 2017

ClusterFuzz has detected this issue as fixed in range 512182:512248.

Detailed report: https://clusterfuzz.com/testcase?key=5927606896820224

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Floating-point-exception
Crash Address: 
Crash State:
  safe_browsing::dmg::HFSForkReadStream::Seek
  safe_browsing::dmg::HFSBTreeIterator::Init
  start
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=512182:512248

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5927606896820224

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Oct 28 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5927606896820224 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment