UpdateWindowTitle() DCHECKs when there is no close button |
||
Issue description
Chrome Version : 63.0.3236.0
OS Version: OS X 10.12.6
This test:
TEST_F(DialogTest, UpdateWindowTitleWithNoClose) {
dialog()->set_show_close_button(false);
dialog()->set_title(base::ASCIIToUTF16("Title"));
dialog()->GetWidget()->UpdateWindowTitle();
}
triggers
51823:775:1027/151301.477671:1229424916069475:FATAL:bubble_frame_view.cc(375)] Check failed: title_insets.right() == width() - title_label_right (13 vs. 28)
0 libbase.dylib 0x000000010671c17e base::debug::StackTrace::StackTrace(unsigned long) + 174
1 libbase.dylib 0x000000010671c23d base::debug::StackTrace::StackTrace(unsigned long) + 29
2 libbase.dylib 0x000000010671a4ec base::debug::StackTrace::StackTrace() + 28
3 libbase.dylib 0x00000001067b380f logging::LogMessage::~LogMessage() + 479
4 libbase.dylib 0x00000001067b1175 logging::LogMessage::~LogMessage() + 21
5 libviews.dylib 0x00000001053ecb20 views::BubbleFrameView::Layout() + 1424
6 libviews.dylib 0x00000001055646b1 views::View::SetBoundsRect(gfx::Rect const&) + 113
7 libviews.dylib 0x0000000105564611 views::View::SetBounds(int, int, int, int) + 417
8 libviews.dylib 0x00000001055bb316 views::NonClientView::LayoutFrameView() + 102
9 libviews.dylib 0x00000001055bb51d views::NonClientView::Layout() + 45
10 libviews.dylib 0x000000010559a261 views::Widget::UpdateWindowTitle() + 177
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by tapted@chromium.org
, Oct 27 2017ahh, this is fixed by TEST_F(DialogTest, UpdateWindowTitleWithNoClose) { dialog()->set_show_close_button(false); dialog()->GetWidget()->non_client_view()->ResetWindowControls(); dialog()->set_title(base::ASCIIToUTF16("Title")); dialog()->GetWidget()->UpdateWindowTitle(); } maybe there's nothing to do here....