Incorrect-function-pointer-type in egl::Display::initialize |
||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5237466855636992 Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer Job Type: libfuzzer_chrome_ubsan Platform Id: linux Crash Type: Incorrect-function-pointer-type Crash Address: Crash State: egl::Display::initialize egl::Display::initialize egl::Initialize Sanitizer: undefined (UBSAN) Recommended Security Severity: Medium Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=511275:511297 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5237466855636992 Issue filed automatically. See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
,
Oct 27 2017
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 27 2017
,
Oct 28 2017
,
Oct 30 2017
[Bulk Edit] URGENT - PTAL. M63 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Thank you.
,
Nov 1 2017
,
Nov 2 2017
I'm not quite sure if this is legit (we have an actual type mismatch) or not (type identity across DLLs is always iffy). It's unlikely to be a security bug though, if this is legit, this would happen at initialization time, before the GPU process is exposed to any untrusted data. Still, worth getting to the bottom of it, in particular, this means we're not getting ubsan coverage of ANGLE fuzzers. Unfortunately the regression range is useless, because it points to my patch that fixed the GPU fuzzers (https://chromium.googlesource.com/chromium/src/+/1a72ba63243487773d433c75541a19098cce5d07).
,
Nov 2 2017
Antoine, this is actually a duplicate of issue 764198 , which was a duplicate of issue 695697 , which was a duplicate of issue 692274 . I never was able to get to the bottom of it. It's something to do with how the jump across the DLL boundary works. Nicolas didn't SwiftShader have the same problem? Do you know how you fixed it? Regardless this is not a security issue.
,
Nov 2 2017
Yes, this looks similar to crbug.com/737384#c24
,
Nov 2 2017
Maybe exporting PlatformMethods (https://cs.chromium.org/chromium/src/third_party/angle/include/platform/Platform.h?type=cs&sq=package:chromium&l=267) would help, since that crosses the DLL boundary? I'm not positive that's it, though. @mmoroz, do you know if there's a way to suppress this error, so that we can have "interesting" ubsan coverage (this just fails at initialization).
,
Nov 2 2017
Yes, I think we can suppress it via ubsan_suppressions with something like: Incorrect-function-pointer-type:angle/src/libANGLE Let me test it locally and report how it works. If it's fine, I can update suppressions on ClusterFuzz side.
,
Nov 2 2017
Yes, that works ("function:" instead of "Incorrect-function-pointer-type:"), but there is one more similar error happening after the suppression:
$ UBSAN_OPTIONS=suppressions=./test.txt:halt_on_error=1 ~/Projects/new/chromium/src/out/ubsan/gpu_angle_passthrough_fuzzer ./clusterfuzz-testcase-minimized-5237466855636992
../../third_party/angle/src/common/event_tracer.cpp:18:9: runtime error: call to function angle::(anonymous namespace)::ANGLEPlatformImpl_getTraceCategoryEnabledFlag(angle::PlatformMethods*, char const*) through pointer to incorrect function type 'const unsigned char *(*)(angle::PlatformMethods *, const char *)'
ui/gl/angle_platform_impl.cc:40: note: angle::(anonymous namespace)::ANGLEPlatformImpl_getTraceCategoryEnabledFlag(angle::PlatformMethods*, char const*) defined here
#0 0x7fd7159b05bb in angle::GetTraceCategoryEnabledFlag(char const*) third_party/angle/src/common/event_tracer.cpp:18:9
#1 0x7fd715a3ae21 in egl::Display::initialize() third_party/angle/src/libANGLE/Display.cpp:444:5
#2 0x7fd715949348 in egl::Initialize(void*, int*, int*) third_party/angle/src/libGLESv2/entry_points_egl.cpp:88:28
#3 0xaf7f5f in gl::GLSurfaceEGL::InitializeDisplay(_XDisplay*) ui/gl/gl_surface_egl.cc:813:10
#4 0xaf7535 in gl::GLSurfaceEGL::InitializeOneOff(_XDisplay*) ui/gl/gl_surface_egl.cc:564:3
#5 0x187fb31 in gl::init::InitializeGLOneOffPlatform() ui/gl/init/gl_initializer_x11.cc:168:12
#6 0x187b54f in gl::init::InitializeGLOneOffImplementation(gl::GLImplementation, bool, bool, bool, bool) ui/gl/init/gl_factory.cc:81:43
#7 0x809165 in gpu::(anonymous namespace)::CommandBufferSetup::CommandBufferSetup() gpu/command_buffer/tests/fuzzer_main.cc:291:5
#8 0x808e86 in __cxx_global_var_init gpu/command_buffer/tests/fuzzer_main.cc:471:35
#9 0x1a4eb0c in __libc_csu_init (/usr/local/google/home/mmoroz/Projects/new/chromium/src/out/ubsan/gpu_angle_passthrough_fuzzer+0x1a4eb0c)
#10 0x7fd71a278ed4 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:246
#11 0x7ef028 in _start (/usr/local/google/home/mmoroz/Projects/new/chromium/src/out/ubsan/gpu_angle_passthrough_fuzzer+0x7ef028)
Do we need to ignore it as well? Then the following suppressions file is needed:
function:angle/src/libANGLE
function:angle/src/common/event_tracer.cpp
,
Nov 2 2017
mmoroz, is that a legitimate or spurious error? It seems like the same type naively, although it doesn't list the return type.
,
Nov 2 2017
Or is it the difference in const char * and char const *?
,
Nov 2 2017
@#12: I think we should ignore as well. @#13-14: I don't think it's char const* vs const char* (that's the same type), but I suspect there are 2 definitions of angle::PlatformMethods, one in the fuzzer executable and one in the ANGLE DLL (so effectively the RTTI info is duplicated, and ubsan treats it as different types). I suspect exporting the struct would fix that, but I'm not sure.
,
Nov 2 2017
As I read the code, I see the following:
using GetTraceCategoryEnabledFlagFunc = const unsigned char *(*)(PlatformMethods *platform,
const char *categoryName);
inline const unsigned char *DefaultGetTraceCategoryEnabledFlag(PlatformMethods *platform,
const char *categoryName)
{
return nullptr;
}
and then we initialize the struct member like:
GetTraceCategoryEnabledFlagFunc getTraceCategoryEnabledFlag = DefaultGetTraceCategoryEnabledFlag;
Do we overwrite that filed anywhere alter?
If not, I don't see any mistake... "char const" seems to be used just a few times in unrelated places: https://cs.chromium.org/search/?q=%22char+const%22+file:%5Esrc/third_party/angle/+package:%5Echromium$&type=cs
With that, it feels reasonable to use the suppressions suggested in the end of c#12. Sounds good?
,
Nov 2 2017
@#16: we do overwrite it here: https://cs.chromium.org/chromium/src/ui/gl/angle_platform_impl.cc?q=angle::Initialize&sq=package:chromium&l=173 But it has the same prototype (we'd have a compile error otherwise), so that's why I think it's a ODR vs DLL issue. See https://stackoverflow.com/questions/27976687/clangs-ubsan-function-pointer-is-this-illegal which seems to be roughly the same issue. Suggested suppressions SGTM, though we may want to remove them eventually if we manage to fix this.
,
Nov 2 2017
Supressions also SGTM, agree it would be nice to fix this at some point.
,
Nov 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/clusterfuzz/+/129693886c74ddaad5615ba6d37185e8ebe91e6b commit 129693886c74ddaad5615ba6d37185e8ebe91e6b Author: Max Moroz <mmoroz@google.com> Date: Thu Nov 02 20:18:01 2017
,
Nov 3 2017
CF cannot reproduce the crash anymore due to suppressions in place: https://clusterfuzz.com/v2/testcase-detail/5237466855636992?noredirect=1
,
Nov 4 2017
I can confirm that adding __attribute__((visibility("default"))) to PlatformMethods fixes this error.
,
Nov 6 2017
Thanks Antoine! That seems like a very easy fix.
,
Nov 7 2017
Should we remove any of the suppressions now? Right now we have: # https://crbug.com/778918 : "function" error reports hapen due to ODR vs DLL # violation, but not because of the function pointer type mistmatch. function:angle/src/libANGLE function:angle/src/common/event_tracer.cpp # Similar to the one above, https://crbug.com/781168. function:ui/gl/gl_bindings_autogen_gl.cc
,
Nov 7 2017
I haven't patched ANGLE yet. Sorry, I will prioritize this and get in soon.
,
Nov 7 2017
,
Nov 7 2017
That's ok, I don't mind to keep suppressions as long as you need. Just let me know if I should modify them or do anything else :)
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/8b920b211d7363daef0d5fb8d2bd69f3253ab033 commit 8b920b211d7363daef0d5fb8d2bd69f3253ab033 Author: Jamie Madill <jmadill@chromium.org> Date: Mon Nov 13 21:19:01 2017 Export angle::PlatformMethods. This should fix undefined function call sanitizer warnings. BUG= chromium:778918 Change-Id: I718d58edd7b75a3fca1089edc4df7f3251d85153 Reviewed-on: https://chromium-review.googlesource.com/767152 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/8b920b211d7363daef0d5fb8d2bd69f3253ab033/include/platform/Platform.h
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/c2eb32bad8de1c2033846db3f9e29d6a0af45095 commit c2eb32bad8de1c2033846db3f9e29d6a0af45095 Author: Jamie Madill <jmadill@chromium.org> Date: Mon Nov 13 21:53:14 2017 Revert "Export angle::PlatformMethods." This reverts commit 8b920b211d7363daef0d5fb8d2bd69f3253ab033. Reason for revert: This had a syntax error and skipped the compile step, so went undetected. BUG= chromium:778918 Original change's description: > Export angle::PlatformMethods. > > This should fix undefined function call sanitizer warnings. > > BUG= chromium:778918 > > Change-Id: I718d58edd7b75a3fca1089edc4df7f3251d85153 > Reviewed-on: https://chromium-review.googlesource.com/767152 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=jmadill@chromium.org,piman@chromium.org Change-Id: I1825ce88bc82867a983bb08cd6732caff54f061c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:778918 Reviewed-on: https://chromium-review.googlesource.com/767128 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/c2eb32bad8de1c2033846db3f9e29d6a0af45095/include/platform/Platform.h
,
Nov 13 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/f62b5e3d5d2facd2e3d3d2decf9cd28ba996762c commit f62b5e3d5d2facd2e3d3d2decf9cd28ba996762c Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Mon Nov 13 23:20:11 2017 Roll skia/third_party/externals/angle2/ d5d3099e3..c2eb32bad (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/d5d3099e3cb7..c2eb32bad8de $ git log d5d3099e3..c2eb32bad --date=short --no-merges --format='%ad %ae %s' 2017-11-13 jmadill Revert "Export angle::PlatformMethods." 2017-11-13 jmadill Use more gl::Error in IndexDataManager. 2017-11-13 jmadill Export angle::PlatformMethods. Created with: roll-dep skia/third_party/externals/angle2 BUG= 778918 , 778918 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=brianosman@google.com Change-Id: I029b5d98e0b428ea5b048dca9256f2611f6ae858 Reviewed-on: https://skia-review.googlesource.com/71020 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/f62b5e3d5d2facd2e3d3d2decf9cd28ba996762c/DEPS
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a06a04a5de356a41051abbad5565c0b018e88a41 commit a06a04a5de356a41051abbad5565c0b018e88a41 Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Tue Nov 14 00:34:57 2017 Roll src/third_party/angle/ 7af63727f..c2eb32bad (4 commits) https://chromium.googlesource.com/angle/angle.git/+log/7af63727f058..c2eb32bad8de $ git log 7af63727f..c2eb32bad --date=short --no-merges --format='%ad %ae %s' 2017-11-13 jmadill Revert "Export angle::PlatformMethods." 2017-11-13 jmadill Use more gl::Error in IndexDataManager. 2017-11-13 jmadill Export angle::PlatformMethods. 2017-11-13 cwallez Avoid redundant BindingPointer::set in setBufferBinding Created with: roll-dep src/third_party/angle BUG= 778918 , 778918 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2fcabd0e3fe5a80a46f79445732bf0f47ddb6f0f Reviewed-on: https://chromium-review.googlesource.com/767034 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516119} [modify] https://crrev.com/a06a04a5de356a41051abbad5565c0b018e88a41/DEPS
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05f818e2ff5921f2f4547c0ecb2d42224db8501c commit 05f818e2ff5921f2f4547c0ecb2d42224db8501c Author: Jamie Madill <jmadill@chromium.org> Date: Tue Nov 14 00:51:43 2017 Add ANGLE includes to ui/gl cross-platform. The ANGLE platform methods layer is imported on multiple OS configs. This rule change should allow better parsing of the platform header dependencies by the bot analyze step. BUG= 778918 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2fd1e4b9b7cf2b89c3e7dce406b28afd7ad21d06 Reviewed-on: https://chromium-review.googlesource.com/767490 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#516123} [modify] https://crrev.com/05f818e2ff5921f2f4547c0ecb2d42224db8501c/ui/gl/BUILD.gn
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/ff7aac5e4f5dfc86b820f135818d62e1962ab40d commit ff7aac5e4f5dfc86b820f135818d62e1962ab40d Author: Jamie Madill <jmadill@chromium.org> Date: Tue Nov 14 04:34:52 2017 Re-land "Export angle::PlatformMethods." This should fix undefined function call sanitizer warnings. Re-land fixes the build and uses proper export annotation. Also fixes the missing source includes in BUILD.gn for libANGLE so future changes to Platform.h (and other includes) will get picked up by the dependency analyzer step. BUG= chromium:778918 Change-Id: I92cc8a43bbbdc70de50a67f73b223d8f903cd6cd Reviewed-on: https://chromium-review.googlesource.com/767111 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> [modify] https://crrev.com/ff7aac5e4f5dfc86b820f135818d62e1962ab40d/BUILD.gn [modify] https://crrev.com/ff7aac5e4f5dfc86b820f135818d62e1962ab40d/include/platform/Platform.h
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ecd0c6269dc111247f6b3d678253e8c3bdd6480 commit 0ecd0c6269dc111247f6b3d678253e8c3bdd6480 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Tue Nov 14 04:35:22 2017 Roll src/third_party/skia/ 0030c5ed3..430ee07db (8 commits) https://skia.googlesource.com/skia.git/+log/0030c5ed3ca6..430ee07db34f $ git log 0030c5ed3..430ee07db --date=short --no-merges --format='%ad %ae %s' 2017-11-13 angle-deps-roller Roll skia/third_party/externals/angle2/ c2eb32bad..8d6af086d (1 commit) 2017-11-13 angle-deps-roller Roll skia/third_party/externals/angle2/ d5d3099e3..c2eb32bad (3 commits) 2017-11-13 brianosman Improve zoom window in Viewer 2017-11-13 ethannicholas SPIR-V switch statement support 2017-11-13 bungeman Revert "Alloc glyph image correctly for SkMask::k3D_Format." 2017-11-13 egdaniel Move pixel config getter to private in GrBackendSurface 2017-11-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 7af63727f..d5d3099e3 (1 commit) 2017-11-10 bungeman Alloc glyph image correctly for SkMask::k3D_Format. Created with: roll-dep src/third_party/skia BUG= 778918 , 778918 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I5c0f4a63cb5a50e7e6c486f907040a68cb1fd520 Reviewed-on: https://chromium-review.googlesource.com/768328 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516192} [modify] https://crrev.com/0ecd0c6269dc111247f6b3d678253e8c3bdd6480/DEPS
,
Nov 14 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/9b9010d875176867d763f3bc4a493296c27685a2 commit 9b9010d875176867d763f3bc4a493296c27685a2 Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Tue Nov 14 05:27:02 2017 Roll skia/third_party/externals/angle2/ 8d6af086d..ff7aac5e4 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/8d6af086d478..ff7aac5e4f5d $ git log 8d6af086d..ff7aac5e4 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 jmadill Re-land "Export angle::PlatformMethods." 2017-11-13 jmadill Buffer11: Cache latest buffer storage. Created with: roll-dep skia/third_party/externals/angle2 BUG= 778918 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=brianosman@google.com Change-Id: I3381d74504d8970d9a723f70ea312ca188103715 Reviewed-on: https://skia-review.googlesource.com/71082 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/9b9010d875176867d763f3bc4a493296c27685a2/DEPS
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/225868d1b4daffd483ff643ae26180498e99b06d commit 225868d1b4daffd483ff643ae26180498e99b06d Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Tue Nov 14 06:33:37 2017 Roll src/third_party/skia/ 430ee07db..9b9010d87 (1 commit) https://skia.googlesource.com/skia.git/+log/430ee07db34f..9b9010d87517 $ git log 430ee07db..9b9010d87 --date=short --no-merges --format='%ad %ae %s' 2017-11-14 angle-deps-roller Roll skia/third_party/externals/angle2/ 8d6af086d..ff7aac5e4 (2 commits) Created with: roll-dep src/third_party/skia BUG= 778918 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I8cf2b8f8a2e029949ddc8105ea012a84718ff4e8 Reviewed-on: https://chromium-review.googlesource.com/768322 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516216} [modify] https://crrev.com/225868d1b4daffd483ff643ae26180498e99b06d/DEPS
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/491735a9660349993d6daa16d85919d346aa0844 commit 491735a9660349993d6daa16d85919d346aa0844 Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Tue Nov 14 08:22:43 2017 Roll src/third_party/angle/ 36f342433..ff7aac5e4 (1 commit) https://chromium.googlesource.com/angle/angle.git/+log/36f34243334f..ff7aac5e4f5d $ git log 36f342433..ff7aac5e4 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 jmadill Re-land "Export angle::PlatformMethods." Created with: roll-dep src/third_party/angle BUG= 778918 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2356b9e91c2950edfe3dc88097ad654b99373f34 Reviewed-on: https://chromium-review.googlesource.com/768573 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516230} [modify] https://crrev.com/491735a9660349993d6daa16d85919d346aa0844/DEPS
,
Nov 14 2017
mmoroz: Can you try lifting one or both of the ANGLE suppressions?
,
Nov 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/clusterfuzz/+/727e9acc5edd38fdc16b4200ceab212b485ef48f commit 727e9acc5edd38fdc16b4200ceab212b485ef48f Author: Max Moroz <mmoroz@google.com> Date: Tue Nov 14 16:51:15 2017
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/740aa41ddf59082ea7d92be12b6ae335bf7d5efa commit 740aa41ddf59082ea7d92be12b6ae335bf7d5efa Author: Jamie Madill <jmadill@chromium.org> Date: Tue Nov 14 16:52:19 2017 Fix angle::Platform export definitions. This was only showing up in the GYP build on Windows. BUG= chromium:778918 Change-Id: Ib9db0c928474be887ec1f46d7e99c0a3dedfb9e0 Reviewed-on: https://chromium-review.googlesource.com/768947 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/740aa41ddf59082ea7d92be12b6ae335bf7d5efa/src/libGLESv2/libGLESv2.def [modify] https://crrev.com/740aa41ddf59082ea7d92be12b6ae335bf7d5efa/include/platform/Platform.h [modify] https://crrev.com/740aa41ddf59082ea7d92be12b6ae335bf7d5efa/src/libANGLE/Platform.cpp
,
Nov 14 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/ffad2566b31bf561188d101cd9817f944c94e0be commit ffad2566b31bf561188d101cd9817f944c94e0be Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Tue Nov 14 18:17:44 2017 Roll skia/third_party/externals/angle2/ f4f293eff..740aa41dd (1 commit) https://chromium.googlesource.com/angle/angle.git/+log/f4f293effbc6..740aa41ddf59 $ git log f4f293eff..740aa41dd --date=short --no-merges --format='%ad %ae %s' 2017-11-14 jmadill Fix angle::Platform export definitions. Created with: roll-dep skia/third_party/externals/angle2 BUG= 778918 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=brianosman@google.com Change-Id: I9f0d33e3839199c41357635fd712f2138c179cf2 Reviewed-on: https://skia-review.googlesource.com/71400 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/ffad2566b31bf561188d101cd9817f944c94e0be/DEPS
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/623c12ae87a0f9e1beb9a9e394c8f7df34da8a4c commit 623c12ae87a0f9e1beb9a9e394c8f7df34da8a4c Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Tue Nov 14 20:47:39 2017 Roll src/third_party/skia/ 339b84e78..3d469a389 (5 commits) https://skia.googlesource.com/skia.git/+log/339b84e78cc5..3d469a389434 $ git log 339b84e78..3d469a389 --date=short --no-merges --format='%ad %ae %s' 2017-11-14 angle-deps-roller Roll skia/third_party/externals/angle2/ 740aa41dd..1d33c2196 (1 commit) 2017-11-14 mtklein "support" 3D masks like Ganesh does 2017-11-14 mtklein remove platform_font_name() 2017-11-14 benjaminwagner Add Win2016 jobs. 2017-11-14 angle-deps-roller Roll skia/third_party/externals/angle2/ f4f293eff..740aa41dd (1 commit) Created with: roll-dep src/third_party/skia BUG= 778918 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I7a181e869355df9018b3fb8fab5511709d20a531 Reviewed-on: https://chromium-review.googlesource.com/769332 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516416} [modify] https://crrev.com/623c12ae87a0f9e1beb9a9e394c8f7df34da8a4c/DEPS
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d80f12d57bf1d1d88efa5db7a40ff726af722a70 commit d80f12d57bf1d1d88efa5db7a40ff726af722a70 Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Tue Nov 14 21:01:06 2017 Roll src/third_party/angle/ f4f293eff..e8afa9025 (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/f4f293effbc6..e8afa90250dd $ git log f4f293eff..e8afa9025 --date=short --no-merges --format='%ad %ae %s' 2017-09-27 geofflang Make GL_ANGLE_framebuffer_blit enableable. 2017-11-13 cwallez Fix standalone mac compilation 2017-11-14 jmadill Fix angle::Platform export definitions. Created with: roll-dep src/third_party/angle BUG= 778918 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I3e60c1e4f36c6c4008ca08cde249bc810cd5bd27 Reviewed-on: https://chromium-review.googlesource.com/769166 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516420} [modify] https://crrev.com/d80f12d57bf1d1d88efa5db7a40ff726af722a70/DEPS
,
Nov 16 2017
ClusterFuzz testcase 5237466855636992 is flaky and no longer crashes, so closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Nov 16 2017
Hum. Max, is that what we wanted?
,
Nov 16 2017
Yes, we've added suppressions ~2 weeks ago, since then CF could not reproduce the crash as well as couldn't find a new reproducer. It is being marked as "flaky", because we changed the suppressions, and the crash became unreproducible even with the original crash revision. Usually it is flakiness that we do not control, and we mark the issue WontFix by default. However, in this particular case, we used suppressions on purpose, and the fix has been landed after that. Marking as Verified.
,
Jun 26 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by sheriffbot@chromium.org
, Oct 27 2017