New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778914 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

InsertHorizontalRule command crashes with unusual HTML

Project Member Reported by ClusterFuzz, Oct 27 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5092110801043456

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000010
Crash State:
  blink::RootEditableElement
  blink::DeleteSelectionCommand::RemoveRedundantBlocks
  blink::DeleteSelectionCommand::DoApply
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=464127:464504

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5092110801043456

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org pnangunoori@chromium.org
Components: Blink
Labels: M-62 Test-Predator-Wrong
Owner: yutak@chromium.org
Status: Assigned (was: Untriaged)
Using the provided regression range assigning to the possible suspect as per the change made for the file, “EditingUtilities.cpp”
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/7d8d866c5fbd4b9c5fe0e0ce39a215d8a731dff4

@yutak -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.

Comment 2 by yutak@chromium.org, Oct 27 2017

Components: -Blink Blink>Editing
Owner: ----
Status: Untriaged (was: Assigned)
That change is totally irelevant. Wait for editing team to triage.
Owner: rlanday@chromium.org
Status: Assigned (was: Untriaged)
Using the provided regression range assigning to the possible suspect as per the change made for the file, “DeleteSelectionCommand.cpp”
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/d6ef615a1a2154d3435b9a09afcd8f6cd929f275

@rlanday -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.
Labels: OS-Mac
Labels: -Pri-1 OS-Linux Pri-3
Owner: yosin@chromium.org
Repros on Mac and Linux (haven't tested other platforms). Bisects to this commit:

https://chromium.googlesource.com/chromium/src/+/1c9b66ff417ace5d8cb6b3358389a891b4eb3a3a
A column-span:all element should always establish a new formatting context.

Note that the test case does use column-span:all, so this kind of makes sense. Before this commit, the test case runs in an infinite loop changing the DOM. After this commit, the test case crashes the renderer.

Passing to yosin@ for triage since it's not caused by my change. Probably not high-pri unless it's happening in the wild.
The bisect range Clusterfuzz is claiming (464127:464504) is in error, by the way. The crash started before then, in 462865.

Comment 7 by yosin@chromium.org, Oct 30 2017

Components: -Blink>Editing Blink>Editing>Command
Owner: ----
Status: Available (was: Assigned)
Summary: InsertHorizontalRule command crashes with unusual HTML (was: Null-dereference READ in blink::RootEditableElement)
Lower to Pri-3 because real world usage of InsertHorizontalRule command with
unusual HTML is low.

Style rule:
*:last-of-type: {... -webkit-column-span:all }

is very unusual.

Project Member

Comment 8 by ClusterFuzz, Nov 7 2017

Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/d6ef615a1a2154d3435b9a09afcd8f6cd929f275 (Improve how DocumentMarkerController updates markers in response to text edits by rlanday@chromium.org)https://chromium.googlesource.com/chromium/src/+/7d8d866c5fbd4b9c5fe0e0ce39a215d8a731dff4 (Rewrite references to "wtf/" to "platform/wtf/" in core/editing. by yutak@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 9 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/d6ef615a1a2154d3435b9a09afcd8f6cd929f275 (Improve how DocumentMarkerController updates markers in response to text edits by rlanday@chromium.org)https://chromium.googlesource.com/chromium/src/+/7d8d866c5fbd4b9c5fe0e0ce39a215d8a731dff4 (Rewrite references to "wtf/" to "platform/wtf/" in core/editing. by yutak@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 10 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/d6ef615a1a2154d3435b9a09afcd8f6cd929f275 (Improve how DocumentMarkerController updates markers in response to text edits by rlanday@chromium.org)https://chromium.googlesource.com/chromium/src/+/7d8d866c5fbd4b9c5fe0e0ce39a215d8a731dff4 (Rewrite references to "wtf/" to "platform/wtf/" in core/editing. by yutak@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 11 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/d6ef615a1a2154d3435b9a09afcd8f6cd929f275 (Improve how DocumentMarkerController updates markers in response to text edits by rlanday@chromium.org)https://chromium.googlesource.com/chromium/src/+/7d8d866c5fbd4b9c5fe0e0ce39a215d8a731dff4 (Rewrite references to "wtf/" to "platform/wtf/" in core/editing. by yutak@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 12 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/d6ef615a1a2154d3435b9a09afcd8f6cd929f275 (Improve how DocumentMarkerController updates markers in response to text edits by rlanday@chromium.org)https://chromium.googlesource.com/chromium/src/+/7d8d866c5fbd4b9c5fe0e0ce39a215d8a731dff4 (Rewrite references to "wtf/" to "platform/wtf/" in core/editing. by yutak@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 13 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/d6ef615a1a2154d3435b9a09afcd8f6cd929f275 (Improve how DocumentMarkerController updates markers in response to text edits by rlanday@chromium.org)https://chromium.googlesource.com/chromium/src/+/7d8d866c5fbd4b9c5fe0e0ce39a215d8a731dff4 (Rewrite references to "wtf/" to "platform/wtf/" in core/editing. by yutak@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 14 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/d6ef615a1a2154d3435b9a09afcd8f6cd929f275 (Improve how DocumentMarkerController updates markers in response to text edits by rlanday@chromium.org)https://chromium.googlesource.com/chromium/src/+/7d8d866c5fbd4b9c5fe0e0ce39a215d8a731dff4 (Rewrite references to "wtf/" to "platform/wtf/" in core/editing. by yutak@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Please ignore the Test-Predator-Auto-CC comment spam above, there was a bug in our script that caused it to create same comment multiple times and also didn't add ccs properly. 
Project Member

Comment 16 by ClusterFuzz, Jan 2 2018

ClusterFuzz has detected this issue as fixed in range 526440:526442.

Detailed report: https://clusterfuzz.com/testcase?key=5092110801043456

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000010
Crash State:
  blink::RootEditableElement
  blink::DeleteSelectionCommand::RemoveRedundantBlocks
  blink::DeleteSelectionCommand::DoApply
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=464127:464504
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=526440:526442

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5092110801043456

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 17 by ClusterFuzz, Jan 2 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 5092110801043456 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment