New issue
Advanced search Search tips

Issue 778875 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 430155


Participants' hotlists:
Hotlist-AnimationWorklet

Show other hotlists

Other hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Animation Worklet - worklet animations should work with slimming paint v2

Project Member Reported by majidvp@chromium.org, Oct 27 2017

Issue description

At the moment both tests that check worklet animations plumbing from main->cc->worklet fail with slimming paint v2 enabled.

We should ensure they work in the mode as this will be default soon.
 
Here is what I have found so far:
 - First we need to make sure appropriate property nodes are creates when there is a composited animation. This is the same as  issue 776533  which the test by pass by also including "will-transform"
 - WorkletAnimation is creating appropriate CompositorAnimationPlayer but for some reason the player is not pushed to impl side! One potential is that we are not marking "SetNeedsCommit" on LTH which means the player is never pushed to impl side.

Components: Internals>Compositing>Animation
I've added virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline.html
 here as well, as it seems related. Feel free to split off into a separate bug if needs be.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0e536bb6e495969f6c0beda02cb9f276b988cd6

commit d0e536bb6e495969f6c0beda02cb9f276b988cd6
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Dec 01 16:16:49 2017

Disable flakey test on Slimming Paint V2.

virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline.html

is very broken with SPv2.

TBR=majidvp@chromium.org

Bug: 778875
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic94109ad74c09dfcbc48f4bf44a3ba134fda0918
Reviewed-on: https://chromium-review.googlesource.com/802637
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520952}
[modify] https://crrev.com/d0e536bb6e495969f6c0beda02cb9f276b988cd6/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2

Labels: -Type-Bug Type-Task
Blocking: 430155
Labels: Pri-3

Sign in to add a comment