New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778869 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

FeedbackTest is flaky on Windows trybots

Project Member Reported by thestig@chromium.org, Oct 27 2017

Issue description

CQ has been rather unhappy. There are a few recent failures.

https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/28613
https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/28621
https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/28638

[ RUN      ] FeedbackTest.ExtraDiagnostics
[3712:4468:1026/170329.308:WARNING:chrome_browser_main_win.cc(612)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=FeedbackTest.ExtraDiagnostics --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7872_29292\results7872_6228\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\iodeoe7n\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7872_29292\d7872_16668" --disable-offline-auto-reload --enable-usermedia-screen-capturing --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[6340:8080:1026/170329.335:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported.
[3712:4468:1026/170329.995:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[3712:7136:1026/170330.006:FATAL:media_stream_manager.cc(1587)] Check failed: requests_.empty().
Backtrace:
	base::debug::StackTrace::StackTrace [0x02C69AE0+32]
	base::debug::StackTrace::StackTrace [0x02C24A3D+13]
	logging::LogMessage::~LogMessage [0x02BCF61E+78]
	content::MediaStreamManager::WillDestroyCurrentMessageLoop [0x01D41AD7+247]
	base::MessageLoop::~MessageLoop [0x02BFCD8D+605]
	base::MessageLoop::`scalar deleting destructor' [0x02BFCB0B+11]
	base::Thread::ThreadMain [0x02C152BA+842]


[ RUN      ] FeedbackTest.AnonymousUser
[2932:3696:1026/171646.348:WARNING:chrome_browser_main_win.cc(612)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=FeedbackTest.AnonymousUser --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4728_23228\results4728_21113\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioswldoi\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4728_23228\d4728_7447" --disable-offline-auto-reload --enable-usermedia-screen-capturing --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[8640:3544:1026/171646.486:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported.
[2932:3696:1026/171647.221:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[2932:7140:1026/171647.231:ERROR:process_win.cc(139)] Unable to terminate process: Access is denied. (0x5)
[2932:4240:1026/171647.239:FATAL:media_stream_manager.cc(1587)] Check failed: requests_.empty().
Backtrace:
	base::debug::StackTrace::StackTrace [0x02FCE160+32]
	base::debug::StackTrace::StackTrace [0x02F8930D+13]
	logging::LogMessage::~LogMessage [0x02F3469E+78]
	content::MediaStreamManager::WillDestroyCurrentMessageLoop [0x020A4517+247]
	base::MessageLoop::~MessageLoop [0x02F6203D+605]
	base::MessageLoop::`scalar deleting destructor' [0x02F61CAB+11]
	base::Thread::ThreadMain [0x02F7A12A+842]

 
One more - almost every try job today has been failing for me: http://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/28715

Is this bug 757243?
Cc: perkj@chromium.org mcasas@chromium.org
Looking at today's tryjobs: https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/30545 and also builds 30547, 30554, 30563, 30564, 30581, 30582.

CCing more media folks since that's where the DCKECK is failing.

Comment 3 by mcasas@chromium.org, Oct 30 2017

Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fda7c113a86197fd958689b382884f7d59496ca

commit 0fda7c113a86197fd958689b382884f7d59496ca
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Oct 31 16:03:42 2017

Clear MediaStreamManager's request list during IO-thread shutdown.

Previously there was a DCHECK expecting the request list to be empty,
which is causing some tests to flake.

Bug:  778869 
Change-Id: I53276aded82752a5a7f01a58e610950e59d062db
Reviewed-on: https://chromium-review.googlesource.com/746663
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512843}
[modify] https://crrev.com/0fda7c113a86197fd958689b382884f7d59496ca/content/browser/renderer_host/media/media_stream_manager.cc

Comment 5 by guidou@chromium.org, Oct 31 2017

Status: Fixed (was: Assigned)

Sign in to add a comment