SecurityStyleExplanations::info_explanations is empty |
||||
Issue description
When running the following browser test using "--enable-features=NetworkService" flag:
BrowserTestNonsecureURLRequest.DidChangeVisibleSecurityStateObserverObsoleteTLSSettings
It fails at:
EXPECT_EQ(
obsolete_description,
base::ASCIIToUTF16(
observer.latest_explanations().info_explanations[0].description));
at //browser/ssl/security_state_tab_helper_browser_tests.cc
because |observer.latest_explanations().info_explanations| is empty.
,
May 17 2018
,
Jun 25 2018
odejesush@ This might be a good bug to get some hands on experience with Network Service. --- How Bug Triage Works: https://docs.google.com/document/d/1xjFD9yJVuUtekJe3a9rpBmYqTOvRuGwML3BP2SBvC3s/edit?usp=sharing More General Info: go/network-service
,
Jul 3
Quick update: This test now fails at line 2593: EXPECT_EQ(blink::kWebSecurityStyleSecure, observer.latest_security_style()); because the latest security style observed is equal to 1, while kWebSecurityStyleSecure is equal to 3. So there must have been a change between the time this bug was reported to today that caused it to fail earlier. Removing this check causes the test to crash at line 2601 net::SSLVersionToString(&protocol, ssl_version); because ssl_version retrieved from net::SSLConnectionStatusToVersion(security_info.connection_status) is 0 and it hits the NOTREACHED() statement in ssl_cipher_suite_names.cc:145. It the test doesn't properly update the security settings for the page when navigation occurs, whereas before it would properly detect that the page was secure, but the TLS settings were obsolete.
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8e2d93a135614c294dfefd7f2b9f97f880954d7 commit f8e2d93a135614c294dfefd7f2b9f97f880954d7 Author: Ovidio Henriquez <odejesush@chromium.org> Date: Wed Aug 01 15:28:42 2018 Update BrowserTestNonsecureURLRequest set up code This change updates the BrowserTestNonsecureURLRequest set up code to use a URLLoaderInterceptor to handle URL requests. Using URLLoaderInterceptor enables the test to work properly when using Network Service code. Bug: 778860 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5898b166967bd8d54608b78444c0aa7c99429df5 Reviewed-on: https://chromium-review.googlesource.com/1150826 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579811} [modify] https://crrev.com/f8e2d93a135614c294dfefd7f2b9f97f880954d7/chrome/browser/ssl/security_state_tab_helper_browsertest.cc [modify] https://crrev.com/f8e2d93a135614c294dfefd7f2b9f97f880954d7/content/public/test/url_loader_interceptor.cc [modify] https://crrev.com/f8e2d93a135614c294dfefd7f2b9f97f880954d7/content/public/test/url_loader_interceptor.h [modify] https://crrev.com/f8e2d93a135614c294dfefd7f2b9f97f880954d7/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Aug 1
The setup for the code needed to be updated to use URLLoaderInterceptor for it to work correctly with the Network Service flag enabled. |
||||
►
Sign in to add a comment |
||||
Comment 1 by laforge@google.com
, Nov 7 2017