Add a --committed-interstitials flag |
||
Issue descriptionestark@, what do you think of landing the creation of the --committted-interstitials flagin a separate CL from https://crrev.com/c/621236 That allows me to slim the CL and work on both dependent CLs together (cf. https://crbug.com/752376#c5 about using the flag directly).
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9539b73972a61a1bf0d38d55ee21bb2eed696a8 commit b9539b73972a61a1bf0d38d55ee21bb2eed696a8 Author: Lucas Garron <lgarron@chromium.org> Date: Tue Oct 31 00:22:09 2017 Create a --committed-interstitials Chrome flag. The flag is exposed in chrome://flags Also deny requests that encounter certificate errors in ChromeContentBrowserClientAllow::CertificateError, causing them to appear like net errors with ERR_INSECURE_RESPONSE. Subsequent CLs will make them behave more and more like old interstitials. Bug: 778857 Change-Id: Ie50f8475db5ae0f6b98f17e17128587fc8553848 Reviewed-on: https://chromium-review.googlesource.com/742136 Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#512688} [modify] https://crrev.com/b9539b73972a61a1bf0d38d55ee21bb2eed696a8/chrome/browser/about_flags.cc [modify] https://crrev.com/b9539b73972a61a1bf0d38d55ee21bb2eed696a8/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/b9539b73972a61a1bf0d38d55ee21bb2eed696a8/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/b9539b73972a61a1bf0d38d55ee21bb2eed696a8/chrome/browser/flag_descriptions.h [modify] https://crrev.com/b9539b73972a61a1bf0d38d55ee21bb2eed696a8/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/b9539b73972a61a1bf0d38d55ee21bb2eed696a8/chrome/common/chrome_switches.cc [modify] https://crrev.com/b9539b73972a61a1bf0d38d55ee21bb2eed696a8/chrome/common/chrome_switches.h [modify] https://crrev.com/b9539b73972a61a1bf0d38d55ee21bb2eed696a8/tools/metrics/histograms/enums.xml
,
Oct 31 2017
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5734f6cffa1a71c25043ee82ec7e67c0f3e06756 commit 5734f6cffa1a71c25043ee82ec7e67c0f3e06756 Author: Matt Menke <mmenke@chromium.org> Date: Tue Oct 31 09:41:55 2017 Disable failing tests when the network service is enabled. SafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata: new test. SSLUITestCommittedInterstitials.ErrorPageType: new test. virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html: old test, flaking a lot (And did my last shift, too). TBR=mmenke@chromium.org Bug: 729849 , 756009 , 756089 , 778857 Change-Id: I08ef0853db0d709e57ce2eb4ca1d3ac3960b6bcc Reviewed-on: https://chromium-review.googlesource.com/746363 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#512791} [modify] https://crrev.com/5734f6cffa1a71c25043ee82ec7e67c0f3e06756/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/5734f6cffa1a71c25043ee82ec7e67c0f3e06756/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation |
||
►
Sign in to add a comment |
||
Comment 1 by lgar...@chromium.org
, Oct 27 2017Summary: Add a --committed-interstitials flag (was: Add a --committted-interstitials flag)