DCHECK in PluginFinder::ReinitializePlugins |
||||||
Issue descriptionChrome Version: 64.0.3250.0 git rev 72709c6ea1b5d1bb9434f676a166b710bc3f20f3 OS: Windows 10 [29316:26468:1026/164247.263:FATAL:plugin_finder.cc(302)] Check failed: identifier_plugin_.find(identifier) == identifier_plugin_.end(). Backtrace: base::debug::StackTrace::StackTrace [0x1058A940+32] (c:\src\gclient\src\base\debug\stack_trace_win.cc:286) base::debug::StackTrace::StackTrace [0x10565C1D+13] (c:\src\gclient\src\base\debug\stack_trace.cc:199) logging::LogMessage::~LogMessage [0x104FDDDE+78] (c:\src\gclient\src\base\logging.cc:581) PluginFinder::ReinitializePlugins [0x11A72965+281] (c:\src\gclient\src\chrome\browser\plugins\plugin_finder.cc:303) PluginsResourceService::Unpack [0x11A74953+101] (c:\src\gclient\src\chrome\browser\plugins\plugins_resource_service.cc:110) web_resource::WebResourceService::OnUnpackFinished [0x11D85CCB+57] (c:\src\gclient\src\components\web_resource\web_resource_service.cc:184) base::internal::FunctorTraits<void (JumpList::*)(std::unique_ptr<JumpList::UpdateTransaction,std::default_delete<JumpList::UpdateTransaction> >) __attribute__((thiscall)),void>::Invoke<const base::WeakPtr<JumpList> &,std::unique_ptr<JumpList::UpdateTransa [0x1197CDE3+51] (c:\src\gclient\src\base\bind_internal.h:194) base::internal::Invoker<base::internal::BindState<void (safe_browsing::V4LocalDatabaseManager::*)(std::unique_ptr<safe_browsing::V4Database,std::default_delete<safe_browsing::V4Database> >) __attribute__((thiscall)),base::WeakPtr<safe_browsing::V4LocalDat [0x11692BB5+77] (c:\src\gclient\src\base\bind_internal.h:334) data_decoder::SafeJsonParserImpl::ReportResults [0x101E483B+183] (c:\src\gclient\src\services\data_decoder\public\cpp\safe_json_parser_impl.cc:62) data_decoder::SafeJsonParserImpl::OnParseDone [0x101E475D+145] (c:\src\gclient\src\services\data_decoder\public\cpp\safe_json_parser_impl.cc:54) base::internal::FunctorTraits<void (content::IndexedDBInternalsUI::*)(std::unique_ptr<base::ListValue,std::default_delete<base::ListValue> >, const base::FilePath &) __attribute__((thiscall)),void>::Invoke<content::IndexedDBInternalsUI *,std::unique_ptr<b [0x0FF8AE41+49] (c:\src\gclient\src\base\bind_internal.h:194) base::internal::Invoker<base::internal::BindState<void (data_decoder::SafeJsonParserImpl::*)(std::unique_ptr<base::Value,std::default_delete<base::Value> >, const base::Optional<std::basic_string<char,std::char_traits<char>,std::allocator<char> > > &) __a [0x101E4B47+63] (c:\src\gclient\src\base\bind_internal.h:324) base::OnceCallback<void (std::unique_ptr<base::Value,std::default_delete<base::Value> >, const base::Optional<std::basic_string<char,std::char_traits<char>,std::allocator<char> > > &)>::Run [0x101E5C97+49] (c:\src\gclient\src\base\callback.h:64) data_decoder::mojom::JsonParser_Parse_ForwardToCallback::Accept [0x101E5C02+256] (c:\src\gclient\src\out\gnrelease32\gen\services\data_decoder\public\interfaces\json_parser.mojom.cc:165) mojo::InterfaceEndpointClient::HandleValidatedMessage [0x105F716C+552] (c:\src\gclient\src\mojo\public\cpp\bindings\lib\interface_endpoint_client.cc:413) mojo::FilterChain::Accept [0x105FAD0B+129] (c:\src\gclient\src\mojo\public\cpp\bindings\lib\filter_chain.cc:40) mojo::InterfaceEndpointClient::HandleIncomingMessage [0x105F7EBC+104] (c:\src\gclient\src\mojo\public\cpp\bindings\lib\interface_endpoint_client.cc:305) mojo::internal::MultiplexRouter::ProcessIncomingMessage [0x105F0724+694] (c:\src\gclient\src\mojo\public\cpp\bindings\lib\multiplex_router.cc:881) mojo::internal::MultiplexRouter::Accept [0x105F0235+295] (c:\src\gclient\src\mojo\public\cpp\bindings\lib\multiplex_router.cc:608) mojo::FilterChain::Accept [0x105FAD0B+129] (c:\src\gclient\src\mojo\public\cpp\bindings\lib\filter_chain.cc:40) mojo::Connector::ReadSingleMessage [0x105F408A+376] (c:\src\gclient\src\mojo\public\cpp\bindings\lib\connector.cc:439) mojo::Connector::ReadAllAvailableMessages [0x105F473D+85] (c:\src\gclient\src\mojo\public\cpp\bindings\lib\connector.cc:469) mojo::Connector::OnHandleReadyInternal [0x105F4613+135] (c:\src\gclient\src\mojo\public\cpp\bindings\lib\connector.cc:376) base::internal::Invoker<base::internal::BindState<void (OneGoogleBarFetcherImpl::*)(const net::URLFetcher *) __attribute__((thiscall)),base::internal::UnretainedWrapper<OneGoogleBarFetcherImpl> >,void (const net::URLFetcher *)>::RunOnce [0x11A578B1+17] (c:\src\gclient\src\base\bind_internal.h:322) net::`anonymous namespace'::CallInt64ToInt [0x10820289+41] (c:\src\gclient\src\net\base\file_stream_context.cc:26) base::internal::Invoker<base::internal::BindState<void (*)(const GURL &, PermissionRequestCreator *, const base::RepeatingCallback<void (bool)> &),GURL>,void (PermissionRequestCreator *, const base::RepeatingCallback<void (bool)> &)>::Run [0x11A7AC8D+21] (c:\src\gclient\src\base\bind_internal.h:331) mojo::SimpleWatcher::OnHandleReady [0x106009BF+229] (c:\src\gclient\src\mojo\public\cpp\system\simple_watcher.cc:275) base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, const mojo::HandleSignalsState &) __attribute__((thiscall)),base::WeakPtr<mojo::SimpleWatcher>,int,unsigned int,mojo::HandleSignalsState>,void ()>::Run [0x10600C40+58] (c:\src\gclient\src\base\bind_internal.h:334) base::debug::TaskAnnotator::RunTask [0x105BF2C5+229] (c:\src\gclient\src\base\debug\task_annotator.cc:55) base::internal::IncomingTaskQueue::RunTask [0x1059E40A+106] (c:\src\gclient\src\base\message_loop\incoming_task_queue.cc:130) base::MessageLoop::RunTask [0x10530E37+439] (c:\src\gclient\src\base\message_loop\message_loop.cc:392) base::MessageLoop::DeferOrRunPendingTask [0x10531124+164] (c:\src\gclient\src\base\message_loop\message_loop.cc:404) base::MessageLoop::DoWork [0x10531368+520] (c:\src\gclient\src\base\message_loop\message_loop.cc:450) base::MessagePumpForUI::DoRunLoop [0x105A0DDD+125] (c:\src\gclient\src\base\message_loop\message_pump_win.cc:174) base::MessagePumpWin::Run [0x105A093C+108] (c:\src\gclient\src\base\message_loop\message_pump_win.cc:58) base::MessageLoop::Run [0x10530887+151] (c:\src\gclient\src\base\message_loop\message_loop.cc:344) base::RunLoop::Run [0x1052465E+110] (c:\src\gclient\src\base\run_loop.cc:121) ChromeBrowserMainParts::MainMessageLoopRun [0x104AD18F+217] (c:\src\gclient\src\chrome\browser\chrome_browser_main.cc:1921) content::BrowserMainLoop::RunMainMessageLoopParts [0x0FE2082D+57] (c:\src\gclient\src\content\browser\browser_main_loop.cc:1208) content::BrowserMainRunnerImpl::Run [0x0FE2319A+140] (c:\src\gclient\src\content\browser\browser_main_runner.cc:140) content::BrowserMain [0x0FE1D918+116] (c:\src\gclient\src\content\browser\browser_main.cc:48) content::RunNamedProcessTypeMain [0x104178C4+236] (c:\src\gclient\src\content\app\content_main_runner.cc:429) content::ContentMainRunnerImpl::Run [0x10417E42+278] (c:\src\gclient\src\content\app\content_main_runner.cc:707) service_manager::Main [0x1042EF07+675] (c:\src\gclient\src\services\service_manager\embedder\main.cc:456) content::ContentMain [0x104177B1+49] (c:\src\gclient\src\content\app\content_main.cc:19) ChromeMain [0x0FA4119C+288] (c:\src\gclient\src\chrome\app\chrome_main.cc:126) MainDllLoader::Launch [0x00C2589A+558] (c:\src\gclient\src\chrome\app\main_dll_loader_win.cc:199) wWinMain [0x00C2154F+1359] (c:\src\gclient\src\chrome\app\chrome_exe_main_win.cc:231) __scrt_common_main_seh [0x00D021E8+246] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) BaseThreadInitThunk [0x742462C4+36] RtlSubscribeWnfStateChangeNotification [0x77440F79+1081] RtlSubscribeWnfStateChangeNotification [0x77440F44+1028] this is likely caused by cl/173551502 because plugin metadata is < gstatic plugin metadata.
,
Oct 27 2017
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f2b8a0a0c0e24850d7838334f08dc05b6d8d6cd commit 9f2b8a0a0c0e24850d7838334f08dc05b6d8d6cd Author: Will Harris <wfh@chromium.org> Date: Fri Oct 27 16:31:40 2017 Update plugins resource service URL to new version. This is because the old URL is used by XP/Vista clients that cannot be updated with new Flash. The new metadata files are already live and landed in 173582711. BUG= 778856 Change-Id: I42c171930518d803398f0d2db0d6420962cecf46 Reviewed-on: https://chromium-review.googlesource.com/741033 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#512201} [modify] https://crrev.com/9f2b8a0a0c0e24850d7838334f08dc05b6d8d6cd/chrome/browser/plugins/plugins_resource_service.cc
,
Oct 31 2017
Issue 779076 has been merged into this issue.
,
Oct 31 2017
I see this DCHECK frequently and can confirm that updating the URL to plugins_3 does not take care of it, unfortunately... :/
,
Oct 31 2017
,
Oct 31 2017
,
Oct 31 2017
,
Oct 31 2017
Fix is up at https://crrev.com/c/746841. Clearing Local State might work around the issue? At least that's the impression I got from issue 779184, and I couldn't reproduce it with a clean profile either.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3705fe7e2cd32c4a53bad2d0d69274c2ac7d3d1f commit 3705fe7e2cd32c4a53bad2d0d69274c2ac7d3d1f Author: Bernhard Bauer <bauerb@chromium.org> Date: Tue Oct 31 17:11:12 2017 Clear plugin map in PluginFinder when reinitializing. The call to clear() was accidentally removed in https://crrev.com/456456, but the bug didn't surface until recently when the remote plugin list was updated before the baked-in one. Other cleanup: * Remove unused FindPlugin() method * Use built-in static instead of base::Singleton * Use SequenceChecker instead of BrowserThread thread checking * Use new base::Value APIs and moar std::unique_ptr TBR: finnur@chromium.org Bug: 778856 Change-Id: I050dd2292882ab047b54f63983cdfd2f7da3aded Reviewed-on: https://chromium-review.googlesource.com/746841 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#512853} [modify] https://crrev.com/3705fe7e2cd32c4a53bad2d0d69274c2ac7d3d1f/chrome/browser/extensions/api/content_settings/content_settings_api.cc [modify] https://crrev.com/3705fe7e2cd32c4a53bad2d0d69274c2ac7d3d1f/chrome/browser/plugins/plugin_finder.cc [modify] https://crrev.com/3705fe7e2cd32c4a53bad2d0d69274c2ac7d3d1f/chrome/browser/plugins/plugin_finder.h [modify] https://crrev.com/3705fe7e2cd32c4a53bad2d0d69274c2ac7d3d1f/chrome/browser/plugins/plugin_finder_unittest.cc
,
Oct 31 2017
,
Nov 9 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wfh@chromium.org
, Oct 27 2017Status: Started (was: Untriaged)